Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2379)

Unified Diff: chrome/renderer/autofill/password_generation_manager_browsertest.cc

Issue 10222017: Make password generation switched by a preference in chrome settings rather than a command line fla… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/password_generation_manager_browsertest.cc
diff --git a/chrome/renderer/autofill/password_generation_manager_browsertest.cc b/chrome/renderer/autofill/password_generation_manager_browsertest.cc
index 69074b0dba50de96fd6665542a32854be707dfdc..bf6c28f96ccac9b745b90faa078f7ac25e0ad4da 100644
--- a/chrome/renderer/autofill/password_generation_manager_browsertest.cc
+++ b/chrome/renderer/autofill/password_generation_manager_browsertest.cc
@@ -112,9 +112,11 @@ TEST_F(PasswordGenerationManagerTest, DetectionTest) {
SetFocused(first_password_element.to<WebNode>());
EXPECT_EQ(0u, generation_manager_->messages().size());
- // Pretend like sync was enabled.
- AutofillMsg_PasswordGenerationEnabled msg(0, true);
- generation_manager_->OnMessageReceived(msg);
+ // Pretend like sync and password generation was enabled.
+ AutofillMsg_PasswordSyncEnabled msg1(0, true);
+ AutofillMsg_PasswordGenerationEnabled msg2(0, true);
+ generation_manager_->OnMessageReceived(msg1);
+ generation_manager_->OnMessageReceived(msg2);
// Now we will send a message once the first password feld is focused.
LoadHTML(kAccountCreationFormHTML);
@@ -135,6 +137,8 @@ TEST_F(PasswordGenerationManagerTest, DetectionTest) {
TEST_F(PasswordGenerationManagerTest, FillTest) {
// Make sure that we are enabled before loading HTML.
+ AutofillMsg_PasswordSyncEnabled sync_msg(0, true);
+ generation_manager_->OnMessageReceived(sync_msg);
AutofillMsg_PasswordGenerationEnabled enabled_msg(0, true);
generation_manager_->OnMessageReceived(enabled_msg);
LoadHTML(kAccountCreationFormHTML);

Powered by Google App Engine
This is Rietveld 408576698