Make password generation switched by a preference in chrome settings rather than a command line fla…

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 242 matching lines @@
   TranslateHelper* translate = new TranslateHelper(render_view);
   new ChromeRenderViewObserver(
       render_view, content_settings, chrome_observer_.get(),
       extension_dispatcher_.get(), translate);
 
   // Used only for testing/automation.
   if (CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kDomAutomationController)) {
     new AutomationRendererHelper(render_view);
   }
-  if (CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kEnablePasswordGeneration)) {
-    new PasswordGenerationManager(render_view);
-  }
+
+  new PasswordGenerationManager(render_view);

[Ilya Sherman, 2012/05/01 22:27:48]

nit: Please omit the blank line between this and the closing curly brace.

[Ilya Sherman, 2012/05/01 22:27:48]

nit: Please move this to be grouped with the other password- and
autofill-related observers.

[zysxqn, 2012/05/03 00:57:24]

Done.

[zysxqn, 2012/05/03 00:57:24]

Done.

+
 }
 
 void ChromeContentRendererClient::SetNumberOfViews(int number_of_views) {
   child_process_logging::SetNumberOfViews(number_of_views);
 }
 
 SkBitmap* ChromeContentRendererClient::GetSadPluginBitmap() {
   return ResourceBundle::GetSharedInstance().GetBitmapNamed(IDR_SAD_PLUGIN);
 }
 
@@ skipping 596 matching lines @@
 bool ChromeContentRendererClient::IsOtherExtensionWithWebRequestInstalled() {
   return extension_dispatcher_->IsOtherExtensionWithWebRequestInstalled();
 }
 
 void ChromeContentRendererClient::RegisterPPAPIInterfaceFactories(
     webkit::ppapi::PpapiInterfaceFactoryManager* factory_manager) {
   factory_manager->RegisterFactory(ChromePPAPIInterfaceFactory);
 }
 
 }  // namespace chrome