Make password generation switched by a preference in chrome settings rather than a command line fla…

chrome/browser/resources/options2/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
 
   //
@@ skipping 1023 matching lines @@
      * @private
      */
     setMetricsReportingSettingVisibility_: function(visible) {
       if (visible)
         $('metricsReportingSetting').style.display = 'block';
       else
         $('metricsReportingSetting').style.display = 'none';
     },
 
     /**
+     * @private

[Ilya Sherman, 2012/05/01 22:27:48]

nit: Please include a comment describing the purpose/use of this function.

[zysxqn, 2012/05/03 00:57:24]

Done.

+     */
+    setPasswordGenerationSettingVisibility_: function(visible) {
+      if (visible) {
+        $('passwordGenerationEnabled').style.display = 'block';
+        $('passwordGenerationEnabledDesc').style.display = 'block';
+      } else {
+        $('passwordGenerationEnabled').style.display = 'none';
+        $('passwordGenerationEnabledDesc').style.display = 'none';
+      }

[Ilya Sherman, 2012/05/01 22:27:48]

nit: Why not set the visibility of the containing <div> element, rather than
setting the visibility individually for the child elements?

[zysxqn, 2012/05/03 00:57:24]

Done.

+    },
+
+    /**
      * Set the font size selected item.
      * @private
      */
     setFontSize_: function(font_size_value) {
       var selectCtl = $('defaultFontSize');
       for (var i = 0; i < selectCtl.options.length; i++) {
         if (selectCtl.options[i].value == font_size_value) {
           selectCtl.selectedIndex = i;
           if ($('Custom'))
             selectCtl.remove($('Custom').index);
@@ skipping 309 matching lines @@
     'setBackgroundModeCheckboxState',
     'setBluetoothState',
     'setCheckRevocationCheckboxState',
     'setContentFilterSettingsValue',
     'setFontSize',
     'setGtkThemeButtonEnabled',
     'setHighContrastCheckboxState',
     'setInstantFieldTrialStatus',
     'setMetricsReportingCheckboxState',
     'setMetricsReportingSettingVisibility',
+    'setPasswordGenerationSettingVisibility',
     'setProfilesInfo',
     'setScreenMagnifierCheckboxState',
     'setSpokenFeedbackCheckboxState',
     'setThemesResetButtonEnabled',
     'setupCloudPrintConnectorSection',
     'setupPageZoomSelector',
     'setupProxySettingsSection',
     'setVirtualKeyboardCheckboxState',
     'showBluetoothSettings',
     'showMouseControls',
@@ skipping 21 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });