Don't use DownloadItem::Rename() in DownloadExtensionTest

Don't use DownloadItem::Rename() in DownloadExtensionTest

BUG=78085
TEST=browser_tests --gtest_filter=DownloadExtensionTest.*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133992

[asanka, 2012-04-25 18:04:55]

The goal is to avoid calling DownloadItem::Rename() from tests. This method is
going away and any replacement mechanism for changing the path of a download is
going to be private.

[benjhayden, 2012-04-25 18:21:18]

On 2012/04/25 18:04:55, asanka wrote:
> The goal is to avoid calling DownloadItem::Rename() from tests. This method is
> going away and any replacement mechanism for changing the path of a download
is
> going to be private.

downloads.setDestination() was spec'd to move a downloaded file. Will that
use-case still be supported?

LGTM otherwise.

[asanka, 2012-04-25 18:33:04]

On 2012/04/25 18:21:18, benjhayden_chromium wrote:
> On 2012/04/25 18:04:55, asanka wrote:
> > The goal is to avoid calling DownloadItem::Rename() from tests. This method
is
> > going away and any replacement mechanism for changing the path of a download
> is
> > going to be private.
> 
> downloads.setDestination() was spec'd to move a downloaded file. Will that
> use-case still be supported?

The DI::Rename() method just changes a member variable holding a path to the
current on-disk file. The API changes will make it so that the member variable
would only be updated as a result of the physical file being renamed. And the
interface for doing that would be private.

downloads.setDestination() would use a different API (which doesn't exist yet,
but would be different from the DI::Rename() that is going away).

> LGTM otherwise.

Thanks!

[commit-bot: I haz the power, 2012-04-25 20:28:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/10222009/2001

[commit-bot: I haz the power, 2012-04-25 21:57:34]

Change committed as 133992