[Chromoting] Update installer archive to check file extensions in one location.

[Chromoting] Update installer archive to check file extensions in one location.

Addresses follow-up comments from 10197005.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134629

[alexeypa (please no reviews), 2012-04-30 16:33:48]

LGTM, but please consider the nits.

http://codereview.chromium.org/10221027/diff/1/remoting/host/installer/build-...
File remoting/host/installer/build-installer-archive.py (right):

http://codereview.chromium.org/10221027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:75: """Calculates destination
file path and creates directory.
nit: This sounds like a perforce mapping. Basically it replaces one path prefix
with another, so you can rename |out_dir| -> |dst_root|, |files_root| ->
|src_root|

http://codereview.chromium.org/10221027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:77: The |files_root| prefix
is stripped from |dst_file| before
What happens if the file name does not start from  |files_root|? Should it be an
error condition?

http://codereview.chromium.org/10221027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:185: if ext in ['.app',
'.prefPane']:
nit: Maybe a better test would be checking if the source is a directory.

[garykac, 2012-04-30 21:24:38]

http://codereview.chromium.org/10221027/diff/1/remoting/host/installer/build-...
File remoting/host/installer/build-installer-archive.py (right):

http://codereview.chromium.org/10221027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:75: """Calculates destination
file path and creates directory.
On 2012/04/30 16:33:48, alexeypa wrote:
> nit: This sounds like a perforce mapping. Basically it replaces one path
prefix
> with another, so you can rename |out_dir| -> |dst_root|, |files_root| ->
> |src_root|

Done.

http://codereview.chromium.org/10221027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:77: The |files_root| prefix
is stripped from |dst_file| before
On 2012/04/30 16:33:48, alexeypa wrote:
> What happens if the file name does not start from  |files_root|? Should it be
an
> error condition?

No. I have a pending cl where I'll be expanding this to allow multiple src_roots
because the src files live in different directories.

http://codereview.chromium.org/10221027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:185: if ext in ['.app',
'.prefPane']:
On 2012/04/30 16:33:48, alexeypa wrote:
> nit: Maybe a better test would be checking if the source is a directory.

Done.

[commit-bot: I haz the power, 2012-04-30 21:25:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/garykac@chromium.org/10221027/4002

[commit-bot: I haz the power, 2012-04-30 23:22:50]

Change committed as 134629