Issue 10221026: Enable the PPAPI audio test under NaCl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10221026: Enable the PPAPI audio test under NaCl (Closed)

Created:
8 years, 8 months ago by Mark Seaborn

Modified:
8 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Enable the PPAPI audio test under NaCl In order to make TestFailures() pass fully, we have to add a NULL callback check to Create(). BUG=none TEST=browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135620

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -2 lines)			Patch
M	chrome/test/ui/ppapi_uitest.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_audio.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ppapi/ppapi_sources.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Mark Seaborn

I can't commit this yet because of (yet another) Gyp bug that breaks incremental builds ...

8 years, 7 months ago (2012-05-02 16:15:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/10221026/4002

8 years, 7 months ago (2012-05-07 06:53:54 UTC) #3

Change committed as 135620