Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 10219010: Revert 133359 - Relanding r133313. (Closed)

Created:
8 years, 8 months ago by willchan no longer on Chromium
Modified:
8 years, 8 months ago
Reviewers:
eroman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 133359 - Relanding r133313. I've reordered the resource request URLRequest cancellations so now I can reland r133313 and not have it assert on renderer resource requests. ========== Revert 133313 - I need to move the assertion to a better place. Assert when URLRequests leak for the main URLRequestContexts. I've already enabled the assertions for all the non-main URLRequestContexts: * safe browsing * system * media * extensions I've squashed those leaks, so now it's time to work on the main URLRequestContext for the profile. I know there are defintely existing l BUG=90971 TEST=none ========== TBR=eroman BUG=90971 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/willchan@chromium.org/10219010/1
8 years, 8 months ago (2012-04-25 00:36:26 UTC) #1
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 02:15:01 UTC) #2
Change committed as 133842

Powered by Google App Engine
This is Rietveld 408576698