content/browser/intents/internal_web_intents_dispatcher_unittest.cc - Issue 10218009: Allow severing connection between dispatcher and injector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/intents/internal_web_intents_dispatcher_unittest.cc

Issue 10218009: Allow severing connection between dispatcher and injector (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix compile issue for browser_tests Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/intents/internal_web_intents_dispatcher.cc ('k') | content/browser/intents/web_intents_dispatcher_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/intents/internal_web_intents_dispatcher_unittest.cc

diff --git a/content/browser/intents/internal_web_intents_dispatcher_unittest.cc b/content/browser/intents/internal_web_intents_dispatcher_unittest.cc

index 17b3b9b5eb3c5067382575f9e784bc0f49fb7af8..da79aa61878d33b1cf1106e2d903f7fafc7f040f 100644

--- a/content/browser/intents/internal_web_intents_dispatcher_unittest.cc

+++ b/content/browser/intents/internal_web_intents_dispatcher_unittest.cc

@@ -57,3 +57,16 @@ TEST_F(InternalWebIntentsDispatcherTest, NotifiesOnReply) {

EXPECT_EQ(1, replied_);

EXPECT_EQ(webkit_glue::WEB_INTENT_REPLY_SUCCESS, notified_reply_type_);

}

+TEST_F(InternalWebIntentsDispatcherTest, CancelAbandonsInjector) {

+ webkit_glue::WebIntentData intent(ASCIIToUTF16("action"),

+ ASCIIToUTF16("type"),

+ ASCIIToUTF16("unserialized_data"));

+ InternalWebIntentsDispatcher* dispatcher = new InternalWebIntentsDispatcher(

+ intent, base::Bind(&InternalWebIntentsDispatcherTest::NotifyReply,

+ base::Unretained(this)));

+ dispatcher->DispatchIntent(web_contents());

+ EXPECT_FALSE(dispatcher->intent_injector_ == NULL);

+ dispatcher->ResetDispatch();

+ EXPECT_TRUE(dispatcher->intent_injector_ == NULL);