Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 10218008: Linux: don't use the DBus power save blocker if DPMS is disabled. (Closed)

Created:
8 years, 8 months ago by Mike Mammarella
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Linux: don't use the DBus power save blocker if DPMS is disabled. On some desktop environments, this can enable DPMS with poor defaults. Also reformat a bunch of poorly-wrapped comments. BUG=111239 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133874

Patch Set 1 #

Patch Set 2 : fix chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -53 lines) Patch
M content/browser/power_save_blocker_linux.cc View 1 10 chunks +84 lines, -53 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mike Mammarella
8 years, 8 months ago (2012-04-24 23:17:03 UTC) #1
sky
This looks reasonable to me, but I don't know anything about this code. Is there ...
8 years, 8 months ago (2012-04-25 03:37:26 UTC) #2
Mike Mammarella
On 2012/04/25 03:37:26, sky wrote: > This looks reasonable to me, but I don't know ...
8 years, 8 months ago (2012-04-25 03:44:53 UTC) #3
sky
LGTM
8 years, 8 months ago (2012-04-25 03:59:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdm@chromium.org/10218008/1
8 years, 8 months ago (2012-04-25 04:00:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdm@chromium.org/10218008/8003
8 years, 8 months ago (2012-04-25 05:29:06 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 08:09:19 UTC) #7
Change committed as 133874

Powered by Google App Engine
This is Rietveld 408576698