Added an argument to AddDomMutationObserver and WaitForDomNode automation hooks to allow the use of…

Added an argument to AddDomMutationObserver and WaitForDomNode automation hooks to allow the use of arbitrary javascript injection functions.

This is necessary to support their use anywhere javascript can be injected.

BUG=None
TEST=functional/apptest.py


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133952

[craigdh, 2012-04-24 22:07:19]

A short cl adding an additional argument to Dom Mutation Observer hooks.

[dennis_jeffrey, 2012-04-24 22:11:53]

LGTM

[Nirnimesh, 2012-04-24 23:25:02]

https://chromiumcodereview.appspot.com/10218006/diff/1/chrome/test/pyautolib/...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/10218006/diff/1/chrome/test/pyautolib/...
chrome/test/pyautolib/pyauto.py:2972: exec_js=None, **kwargs):
would supplying the default arg (PyUITest.ExecuteJavascript) work here?

https://chromiumcodereview.appspot.com/10218006/diff/1/chrome/test/pyautolib/...
chrome/test/pyautolib/pyauto.py:3022: exec_js = PyUITest.ExecuteJavascript if
exec_js is None else exec_js
exec_js = exec_js or PyUITest.ExecuteJavascript

[craigdh, 2012-04-25 00:57:15]

Currently my chair is in use by a giant oscilloscope, so I will upload the new
patch set once it moves...

http://codereview.chromium.org/10218006/diff/1/chrome/test/pyautolib/pyauto.py
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/10218006/diff/1/chrome/test/pyautolib/pyauto.p...
chrome/test/pyautolib/pyauto.py:2972: exec_js=None, **kwargs):
On 2012/04/24 23:25:02, Nirnimesh wrote:
> would supplying the default arg (PyUITest.ExecuteJavascript) work here?

Unfortunately, no, I tried that. Even moving the ExecuteJavascript def before
here doesn't work. It appears you can't reference methods internal to the class
before the class is fully parsed by Python.

http://codereview.chromium.org/10218006/diff/1/chrome/test/pyautolib/pyauto.p...
chrome/test/pyautolib/pyauto.py:3022: exec_js = PyUITest.ExecuteJavascript if
exec_js is None else exec_js
On 2012/04/24 23:25:02, Nirnimesh wrote:
> exec_js = exec_js or PyUITest.ExecuteJavascript

Done. Good point, a callable will never evaluate as False.

[Nirnimesh, 2012-04-25 01:06:18]

LGTM

[commit-bot: I haz the power, 2012-04-25 16:33:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/craigdh@chromium.org/10218006/2003

[commit-bot: I haz the power, 2012-04-25 19:05:49]

Change committed as 133952