chrome/common/extensions/extension.cc - Issue 10217017: Allow features to refer to subkeys in _manifest_features.json.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 10217017: Allow features to refer to subkeys in _manifest_features.json. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Validate gives errors again Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index 5d5045c95f7d2e78ad5ae829e5e89784aeb6b03c..a4824ee736b5a255bf85d4f884cdd4fd6961ff9e 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -1881,8 +1881,7 @@ bool Extension::LoadBackgroundPersistent(

!manifest_->Get(keys::kBackgroundPersistent, &background_persistent))

return true;

- if (!background_persistent->IsType(Value::TYPE_BOOLEAN) ||

- !background_persistent->GetAsBoolean(&background_page_is_persistent_)) {

+ if (!background_persistent->GetAsBoolean(&background_page_is_persistent_)) {

*error = ASCIIToUTF16(errors::kInvalidBackgroundPersistent);

return false;

}