Issue 10217009: [Chrome OS ECHO]: Add default locale to manifest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10217009: [Chrome OS ECHO]: Add default locale to manifest (Closed)

Created:
8 years, 8 months ago by gauravsh

Modified:
8 years, 8 months ago

Reviewers:
rginda, Jorge Lucangeli Obes, Nikita (slow)

CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Chrome OS ECHO]: Add default locale to manifest BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133854

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/chromeos/echo/manifest.json	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/10217009/1

8 years, 8 months ago (2012-04-25 00:00:55 UTC) #4

Nikita (slow)

8 years, 8 months ago (2012-04-25 10:31:23 UTC) #6

https://chromiumcodereview.appspot.com/10217009/diff/1/chrome/browser/resourc...
File chrome/browser/resources/chromeos/echo/manifest.json (right):

https://chromiumcodereview.appspot.com/10217009/diff/1/chrome/browser/resourc...
chrome/browser/resources/chromeos/echo/manifest.json:16: "default_locale": "en",
Shouldn't it be "en-US"? I know that "en" is implicitly translated into "en-US"
but still.

Expand Messages | Collapse Messages