Fix IDB pyauto tests on cros by preventing restore after restart

IndexedDB pyauto tests rely on restarting the browser and navigating to a new tab. On CrOS the restart was causing the previous session's tabs to be restored, which confused the test.

Set a preference to start sessions on the new tab page, , and refactor to avoid polling for results so that failures are detected immediately and with useful error messages.

BUG=123045
TEST=python chrome/test/functional/indexeddb.py
R=nirnimesh@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133993

[jsbell, 2012-04-24 22:07:21]

nirnimesh@ - can you review and try this locally on your CrOS box?

[Nirnimesh, 2012-04-25 19:38:38]

I've tried this locally on my chromeos and mac. Works on both. Thanks

LGTM

http://codereview.chromium.org/10216002/diff/3/chrome/test/functional/PYAUTO_...
File chrome/test/functional/PYAUTO_TESTS (left):

http://codereview.chromium.org/10216002/diff/3/chrome/test/functional/PYAUTO_...
chrome/test/functional/PYAUTO_TESTS:170: # crbug.com/123045
I think you already deleted this. Please re-sync and delete the one from
chromeos section below.

http://codereview.chromium.org/10216002/diff/3/chrome/test/functional/indexed...
File chrome/test/functional/indexeddb.py (right):

http://codereview.chromium.org/10216002/diff/3/chrome/test/functional/indexed...
chrome/test/functional/indexeddb.py:16: def _GetInnerText(self, selector,
**kwargs):
please explicitly use tab_index arg, instead of **kwargs

http://codereview.chromium.org/10216002/diff/3/chrome/test/functional/indexed...
chrome/test/functional/indexeddb.py:23: def _WaitForAndAssertResult(self,
expected, **kwargs):
please explicitly use tab_index arg, instead of **kwargs

http://codereview.chromium.org/10216002/diff/3/chrome/test/functional/indexed...
chrome/test/functional/indexeddb.py:36:
self.assertEqual(self.GetDOMValue(expression, **kwargs), "ok")
use single quotes for string

[jsbell, 2012-04-25 20:42:04]

http://codereview.chromium.org/10216002/diff/3/chrome/test/functional/PYAUTO_...
File chrome/test/functional/PYAUTO_TESTS (left):

http://codereview.chromium.org/10216002/diff/3/chrome/test/functional/PYAUTO_...
chrome/test/functional/PYAUTO_TESTS:170: # crbug.com/123045
On 2012/04/25 19:38:38, Nirnimesh wrote:
> I think you already deleted this. Please re-sync and delete the one from
> chromeos section below.

Oops, thanks. Done.

http://codereview.chromium.org/10216002/diff/3/chrome/test/functional/indexed...
File chrome/test/functional/indexeddb.py (right):

http://codereview.chromium.org/10216002/diff/3/chrome/test/functional/indexed...
chrome/test/functional/indexeddb.py:16: def _GetInnerText(self, selector,
**kwargs):
On 2012/04/25 19:38:38, Nirnimesh wrote:
> please explicitly use tab_index arg, instead of **kwargs

Done.

http://codereview.chromium.org/10216002/diff/3/chrome/test/functional/indexed...
chrome/test/functional/indexeddb.py:23: def _WaitForAndAssertResult(self,
expected, **kwargs):
On 2012/04/25 19:38:38, Nirnimesh wrote:
> please explicitly use tab_index arg, instead of **kwargs

Done.

http://codereview.chromium.org/10216002/diff/3/chrome/test/functional/indexed...
chrome/test/functional/indexeddb.py:28: def _ClearResult(self, **kwargs):
Dropped kwargs here too.

http://codereview.chromium.org/10216002/diff/3/chrome/test/functional/indexed...
chrome/test/functional/indexeddb.py:36:
self.assertEqual(self.GetDOMValue(expression, **kwargs), "ok")
On 2012/04/25 19:38:38, Nirnimesh wrote:
> use single quotes for string

Done.

[commit-bot: I haz the power, 2012-04-25 20:42:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/10216002/10001

[commit-bot: I haz the power, 2012-04-25 21:59:22]

Change committed as 133993