Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 10216001: Adding util methods to deal with Java string arrays using string16. (Closed)

Created:
8 years, 8 months ago by Jay Civelli
Modified:
8 years, 8 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Adding new JNI util methods that deal with Java string arrays and use string16. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M base/android/jni_array.h View 2 chunks +9 lines, -0 lines 0 comments Download
M base/android/jni_array.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jay Civelli
8 years, 8 months ago (2012-04-24 18:04:44 UTC) #1
John Grabowski
LGTM, but to be clear I don't think this code will be exercised upstream yet.
8 years, 8 months ago (2012-04-24 22:15:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/10216001/1
8 years, 8 months ago (2012-04-24 22:16:48 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-24 23:55:33 UTC) #4
Change committed as 133809

Powered by Google App Engine
This is Rietveld 408576698