Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7580)

Unified Diff: chrome/nacl/nacl_ipc_adapter.cc

Issue 10214007: Add an IPC channel between the NaCl loader process and the renderer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/nacl/nacl_ipc_adapter.cc
===================================================================
--- chrome/nacl/nacl_ipc_adapter.cc (revision 135227)
+++ chrome/nacl/nacl_ipc_adapter.cc (working copy)
@@ -12,6 +12,7 @@
#include "base/location.h"
#include "base/memory/scoped_ptr.h"
#include "build/build_config.h"
+#include "ipc/ipc_channel_proxy.h"
namespace {
@@ -118,6 +119,7 @@
locked_data_() {
io_thread_data_.channel_.reset(
new IPC::Channel(handle, IPC::Channel::MODE_SERVER, this));
+ DCHECK(io_thread_data_.channel_->Connect());
dmichael (off chromium) 2012/05/07 20:30:19 You don't want to do this inside DCHECK, since it
bbudge 2012/05/07 21:39:18 I think that's OK. I've seen it in other calls to
}
NaClIPCAdapter::NaClIPCAdapter(scoped_ptr<IPC::Channel> channel,

Powered by Google App Engine
This is Rietveld 408576698