Issue 10214002: Fix commandline and disabling tests for apk based tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10214002: Fix commandline and disabling tests for apk based tests. (Closed)

Created:
8 years, 8 months ago by nilesh

Modified:
8 years, 8 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix commandline and disabling tests for apk based tests. Command for running with a test filter: ./build/android/run_tests.py -s out/Release/base_unittests_apk/base_unittests-debug.apk -f FileUtilTest.* The _disabled file should be base_unittests-debug_disabled BUG=125059 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133838

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	build/android/test_package_apk.py	View	1 chunk	+1 line, -1 line	1 comment	Download
M	testing/android/native_test_apk.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	testing/android/native_test_launcher.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

LGTM! http://codereview.chromium.org/10214002/diff/1/build/android/test_package_apk.py File build/android/test_package_apk.py (right): http://codereview.chromium.org/10214002/diff/1/build/android/test_package_apk.py#newcode31 build/android/test_package_apk.py:31: APK_DATA_DIR = '/data/user/0/org.chromium.native_test/files/' Ha!

8 years, 8 months ago (2012-04-24 22:15:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10214002/1

8 years, 8 months ago (2012-04-24 23:20:10 UTC) #3

Change committed as 133838

Expand Messages | Collapse Messages