Now CHECKs to make sure we log out before clearing the token db

Now CHECKs to make sure we log out before clearing the token db

BUG=121755
TEST=signin/signout, should get no crashes


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133969

[Andrew T Wilson (Slow), 2012-04-25 01:08:19]

PTAL - this is my desperate attempt to see if somehow someone is clearing the
token service outside of SignOut() despite the fact that it's plainly impossible
from looking at the code.

[tim (not reviewing), 2012-04-25 18:37:58]

LGTM

http://codereview.chromium.org/10213013/diff/1/chrome/browser/signin/token_se...
File chrome/browser/signin/token_service.cc (right):

http://codereview.chromium.org/10213013/diff/1/chrome/browser/signin/token_se...
chrome/browser/signin/token_service.cc:142: prefs::kGoogleServicesUsername);
Is there anything else in TokenService that expects / requires SigninManager to
be initialized before it? Not a big deal or a problem in practice (or tests?),
maybe augment the comment just in case.

[Andrew T Wilson (Slow), 2012-04-25 18:44:16]

Will do. I'm planning to nuke this CHECK() eventually (probably before we ship
M20, actually) so we'll remove this dependency there.

[commit-bot: I haz the power, 2012-04-25 18:56:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/atwilson@chromium.org/10213013/9001

[commit-bot: I haz the power, 2012-04-25 20:31:13]

Change committed as 133969