Make downloads.download() respect host permissions

chrome/test/data/extensions/api_test/downloads/test.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // downloads api test
 // browser_tests.exe --gtest_filter=DownloadsApiTest.Downloads
 
 // Comment this out to enable debugging.
 console.debug = function() {};
 
 function debugObject(obj) {
   for (var property in obj) {
     console.debug(property + ': ' + obj[property]);
   }
 }
 
 var downloads = chrome.experimental.downloads;
+window.requestFileSystem  = (window.requestFileSystem ||
+                             window.webkitRequestFileSystem);
+window.BlobBuilder = (window.BlobBuilder ||
+                      window.WebKitBlobBuilder ||
+                      window.MozBlobBuilder);

[ericu, 2012/05/03 17:14:55]

Why MozBlobBuilder?  This won't run on Firefox.

[benjhayden, 2012/05/03 19:38:35]

Done.

 
 chrome.test.getConfig(function(testConfig) {
   function getURL(path) {
     return 'http://localhost:' + testConfig.testServer.port + '/' + path;
   }
 
   var nextId = 0;
   function getNextId() {
     return nextId++;
   }
@@ skipping 70 matching lines @@
       // Test that we can begin a download.
       var downloadId = getNextId();
       console.debug(downloadId);
       downloads.download(
           {'url': SAFE_FAST_URL},
           chrome.test.callback(function(id) {
             chrome.test.assertEq(downloadId, id);
           }));
     },
 
+    function downloadBlob() {
+      // Test that we can begin a download for a blob.
+      var downloadId = getNextId();
+      console.debug(downloadId);
+      function getBlobURL(data, filename, callback) {
+        var dirname = '' + Math.random();
+        function fileSystemError(operation, data) {
+          return function(fileError) {
+            callback(null, {operation: operation,
+                            data: data,
+                            code: fileError.code});
+          }
+        }
+        window.requestFileSystem(TEMPORARY, 5*1024*1024, function(fs) {
+          fs.root.getDirectory(dirname, {create: true, exclusive: true},
+                               function(dirEntry) {
+            dirEntry.getFile(filename, {create: true, exclusive: true},
+                             function(fileEntry) {
+              fileEntry.createWriter(function(fileWriter) {
+                fileWriter.onwriteend = function(e) {
+                  callback(fileEntry.toURL(), null);
+                };
+                fileWriter.onerror = function(e) {
+                  callback(null, ('Write failed: ' + e.toString()));
+                };
+                var bb = new window.BlobBuilder();
+                bb.append(data);
+                fileWriter.write(bb.getBlob());
+              }, fileSystemError('createWriter'));
+            }, fileSystemError('getFile', filename));
+          }, fileSystemError('getDirectory',  dirname));
+        }, fileSystemError('requestFileSystem'));
+      }
+
+      getBlobURL('Lorem ipsum', downloadId + '.txt',
+                 chrome.test.callback(function(blobUrl, blobError) {
+        if (blobError)
+          throw blobError;
+        console.debug(blobUrl);
+        downloads.download(
+            {'url': blobUrl},
+            chrome.test.callback(function(id) {
+              console.debug(id);
+              chrome.test.assertEq(downloadId, id);
+            }));
+      }));
+    },
+
     function downloadOnChanged() {
       // Test that download completion is detectable by an onChanged event
       // listener.
       var downloadId = getNextId();
       console.debug(downloadId);
       var callbackCompleted = chrome.test.callbackAdded();
       function myListener(delta) {
         console.debug(delta.id);
         if ((delta.id != downloadId) ||
             !delta.state)
@@ skipping 605 matching lines @@
       // Valid file URLs are valid URLs.
       var downloadId = getNextId();
       console.debug(downloadId);
       downloads.download(
           {'url': 'file:///'},
           chrome.test.callback(function(id) {
               chrome.test.assertEq(downloadId, id);
             }));
     },
 
-    // TODO(benjhayden): Set up a test ftp server.
+    function downloadInvalidURL7() {
+      // Test that download() rejects javascript urls.
+      downloads.download(
+          {'url': 'javascript:document.write("hello");'},
+          chrome.test.callbackFail(downloads.ERROR_INVALID_URL));
+    },
+
+    function downloadInvalidURL8() {
+      // Test that download() rejects javascript urls.
+      downloads.download(
+          {'url': 'javascript:return false;'},
+          chrome.test.callbackFail(downloads.ERROR_INVALID_URL));
+    },
+
+    function downloadInvalidURL9() {
+      // Test that download() rejects otherwise-valid URLs that fail the host
+      // permissions check.
+      downloads.download(
+          {'url': 'ftp://example.com/example.txt'},
+          chrome.test.callbackFail(downloads.ERROR_INVALID_URL));
+    },
+
+    // TODO(benjhayden): Set up a test ftp server, add ftp://localhost* to
+    // permissions, maybe update downloadInvalidURL9.
     // function downloadAllowFTPURLs() {
     //   // Valid ftp URLs are valid URLs.
     //   var downloadId = getNextId();
     //   console.debug(downloadId);
     //   downloads.download(
     //       {'url': 'ftp://localhost:' + testConfig.testServer.port + '/'},
     //       chrome.test.callback(function(id) {
     //         chrome.test.assertEq(downloadId, id);
     //       }));
     // },
 
-    function downloadInvalidURL7() {
-      // Test that download() rejects javascript urls.
-      downloads.download(
-          {'url': 'javascript:document.write("hello");'},
-          chrome.test.callbackFail('net::ERR_ACCESS_DENIED'));
-    },
-
-    function downloadInvalidURL8() {
-      // Test that download() rejects javascript urls.
-      downloads.download(
-          {'url': 'javascript:return false;'},
-          chrome.test.callbackFail('net::ERR_ACCESS_DENIED'));
-    },
-
     function downloadInvalidMethod() {
       assertThrows(('Invalid value for argument 1. Property \'method\': ' +
                     'Value must be one of: [GET, POST].'),
                    downloads.download,
                    {'url': SAFE_FAST_URL, 'method': 'GOAT'});
     },
 
     function downloadInvalidHeader() {
       // Test that download() disallows setting the Cookie header.
       downloads.download(
@@ skipping 88 matching lines @@
     },
 
     function callNotifyPass() {
       chrome.test.notifyPass();
       setTimeout(chrome.test.callback(function() {
         console.debug('');
       }), 0);
     }
   ]);
 });