chrome/test/data/extensions/api_test/downloads/manifest.json - Issue 10213002: Make downloads.download() respect host permissions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/downloads/manifest.json

Issue 10213002: Make downloads.download() respect host permissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: style Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 {	1 {

2 "name": "chrome.experimental.downloads",	2 "name": "chrome.experimental.downloads",

3 "version": "0.1",	3 "version": "0.1",

4 "manifest_version": 2,	4 "manifest_version": 2,

5 "description": "end-to-end browser test for chrome.experimental.downloads API" ,	5 "description": "end-to-end browser test for chrome.experimental.downloads API" ,

6 "background": {	6 "background": {

7 "scripts": ["test.js"]	7 "scripts": ["test.js"]

8 },	8 },

9 "permissions": ["experimental", "downloads", "http:///", "https:///"]	9 "permissions": [

	10 "experimental",

	11 "downloads",

	12 "http:///",

	13 "https:///",

	14 "file://*",

	15 "filesystem:*",
	ericu 2012/05/03 17:14:55 I don't think you should need either mention of fi I don't think you should need either mention of filesystem: URLs in the manifest. Support for http:/// should automatically grant filesystem:http:///, etc. benjhayden 2012/05/03 19:38:35 Done. Show quoted text On 2012/05/03 17:14:55, ericu wrote: > I don't think you should need either mention of filesystem: URLs in the > manifest. Support for http:/// should automatically grant > filesystem:http:///, etc. Done.
	16 "chrome-extension://fkkgfmjnokdaipgddojcidaofhhadnki/*",

	17 "filesystem:chrome-extension://fkkgfmjnokdaipgddojcidaofhhadnki/*"

	18 ]

10 }	19 }

OLD	NEW