Make downloads.download() respect host permissions

chrome/test/data/extensions/api_test/downloads/test.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // downloads api test
 // browser_tests.exe --gtest_filter=DownloadsApiTest.Downloads
 
 // Comment this out to enable debugging.
 console.debug = function() {};
 
@@ skipping 704 matching lines @@
       // Valid file URLs are valid URLs.
       var downloadId = getNextId();
       console.debug(downloadId);
       downloads.download(
           {'url': 'file:///'},
           chrome.test.callback(function(id) {
               chrome.test.assertEq(downloadId, id);
             }));
     },
 
-    // TODO(benjhayden): Set up a test ftp server.
+    function downloadInvalidURL7() {
+      // Test that download() rejects javascript urls.
+      downloads.download(
+          {'url': 'javascript:document.write("hello");'},
+          chrome.test.callbackFail(downloads.ERROR_INVALID_URL));
+    },
+
+    function downloadInvalidURL8() {
+      // Test that download() rejects javascript urls.
+      downloads.download(
+          {'url': 'javascript:return false;'},
+          chrome.test.callbackFail(downloads.ERROR_INVALID_URL));
+    },
+
+    function downloadInvalidURL9() {
+      // Test that download() rejects otherwise-valid URLs that fail the host
+      // permissions check.
+      downloads.download(
+          {'url': 'ftp://example.com/example.txt'},
+          chrome.test.callbackFail(downloads.ERROR_INVALID_URL));
+    },
+
+    // TODO(benjhayden): Set up a test ftp server, add ftp://localhost* to
+    // permissions, maybe update downloadInvalidURL9.
     // function downloadAllowFTPURLs() {
     //   // Valid ftp URLs are valid URLs.
     //   var downloadId = getNextId();
     //   console.debug(downloadId);
     //   downloads.download(
     //       {'url': 'ftp://localhost:' + testConfig.testServer.port + '/'},
     //       chrome.test.callback(function(id) {
     //         chrome.test.assertEq(downloadId, id);
     //       }));
     // },
 
-    function downloadInvalidURL7() {
-      // Test that download() rejects javascript urls.
-      downloads.download(
-          {'url': 'javascript:document.write("hello");'},
-          chrome.test.callbackFail('net::ERR_ACCESS_DENIED'));
-    },
-
-    function downloadInvalidURL8() {
-      // Test that download() rejects javascript urls.
-      downloads.download(
-          {'url': 'javascript:return false;'},
-          chrome.test.callbackFail('net::ERR_ACCESS_DENIED'));
-    },
-
     function downloadInvalidMethod() {
       assertThrows(('Invalid value for argument 1. Property \'method\': ' +
                     'Value must be one of: [GET, POST].'),
                    downloads.download,
                    {'url': SAFE_FAST_URL, 'method': 'GOAT'});
     },
 
     function downloadInvalidHeader() {
       // Test that download() disallows setting the Cookie header.
       downloads.download(
@@ skipping 88 matching lines @@
     },
 
     function callNotifyPass() {
       chrome.test.notifyPass();
       setTimeout(chrome.test.callback(function() {
         console.debug('');
       }), 0);
     }
   ]);
 });