Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 10212003: Cleanup of network code. (Closed)

Created:
8 years, 8 months ago by kevers
Modified:
8 years, 8 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Cleanup of network code. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133966

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update documentation. #

Patch Set 3 : Merge with trunk. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -346 lines) Patch
M chrome/browser/resources/options2/chromeos/internet_detail.js View 1 2 11 chunks +26 lines, -16 lines 0 comments Download
D chrome/browser/resources/options2/chromeos/internet_network_element.js View 1 chunk +0 lines, -316 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/network_list.js View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/options2/options_bundle.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.h View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kevers
Hi James, Can you please have a look at this CL, which renames the non-descriptive ...
8 years, 8 months ago (2012-04-24 18:37:33 UTC) #1
James Hawkins
LGTM with nit. http://codereview.chromium.org/10212003/diff/1/chrome/browser/resources/options2/chromeos/internet_detail.js File chrome/browser/resources/options2/chromeos/internet_detail.js (right): http://codereview.chromium.org/10212003/diff/1/chrome/browser/resources/options2/chromeos/internet_detail.js#newcode10 chrome/browser/resources/options2/chromeos/internet_detail.js:10: * Network settings constants. These enums ...
8 years, 8 months ago (2012-04-24 18:46:40 UTC) #2
kevers
http://codereview.chromium.org/10212003/diff/1/chrome/browser/resources/options2/chromeos/internet_detail.js File chrome/browser/resources/options2/chromeos/internet_detail.js (right): http://codereview.chromium.org/10212003/diff/1/chrome/browser/resources/options2/chromeos/internet_detail.js#newcode10 chrome/browser/resources/options2/chromeos/internet_detail.js:10: * Network settings constants. These enums usually match their ...
8 years, 8 months ago (2012-04-24 18:51:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/10212003/7001
8 years, 8 months ago (2012-04-25 18:45:58 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 20:19:24 UTC) #5
Change committed as 133966

Powered by Google App Engine
This is Rietveld 408576698