Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 10211013: Do not validity check safe-browsing store if not opened. (Closed)

Created:
8 years, 8 months ago by Scott Hess - ex-Googler
Modified:
8 years, 8 months ago
Reviewers:
mattm
CC:
chromium-reviews
Visibility:
Public.

Description

Do not validity check safe-browsing store if not opened. In case of corruptions, the state of empty_ versus file_ may not be what was expected. BUG=124907 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_store_file.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Scott Hess - ex-Googler
8 years, 8 months ago (2012-04-25 02:02:31 UTC) #1
mattm
On 2012/04/25 02:02:31, shess wrote: lgtm
8 years, 8 months ago (2012-04-25 02:11:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10211013/1
8 years, 8 months ago (2012-04-25 02:12:26 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 03:35:16 UTC) #4
Change committed as 133860

Powered by Google App Engine
This is Rietveld 408576698