Moves media device notification code to chrome/browser

Moves media device notification code to chrome/browser

BUG=NONE
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133946

[vandebo (ex-Chrome), 2012-04-24 21:58:17]

LGTM with nits.

http://codereview.chromium.org/10211008/diff/1/chrome/browser/chrome_browser_...
File chrome/browser/chrome_browser_main_win.h (right):

http://codereview.chromium.org/10211008/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main_win.h:11: #include
"chrome/browser/chrome_browser_main.h"
#include "base/memory/scoped_ptr.h"

http://codereview.chromium.org/10211008/diff/1/chrome/browser/media_gallery/m...
File chrome/browser/media_gallery/media_device_notification_window_win.cc
(right):

http://codereview.chromium.org/10211008/diff/1/chrome/browser/media_gallery/m...
chrome/browser/media_gallery/media_device_notification_window_win.cc:60:
&MediaDeviceNotificationWindowWin::WndProcThunk>;
nit: four spaces

http://codereview.chromium.org/10211008/diff/1/chrome/browser/media_gallery/m...
chrome/browser/media_gallery/media_device_notification_window_win.cc:79: UINT
event_type, DWORD data) {
nit: looks like the first arg will fit on the previous line.

http://codereview.chromium.org/10211008/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/10211008/diff/1/chrome/chrome_browser.gypi#new...
chrome/chrome_browser.gypi:1299:
'browser/media_gallery/media_device_notification_window_win.h',
nit: probably should follow the existing name convention, plural notifications

[tpayne, 2012-04-24 22:59:17]

http://codereview.chromium.org/10211008/diff/1/chrome/browser/chrome_browser_...
File chrome/browser/chrome_browser_main_win.h (right):

http://codereview.chromium.org/10211008/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main_win.h:11: #include
"chrome/browser/chrome_browser_main.h"
On 2012/04/24 21:58:17, vandebo wrote:
> #include "base/memory/scoped_ptr.h"

Done.

http://codereview.chromium.org/10211008/diff/1/chrome/browser/media_gallery/m...
File chrome/browser/media_gallery/media_device_notification_window_win.cc
(right):

http://codereview.chromium.org/10211008/diff/1/chrome/browser/media_gallery/m...
chrome/browser/media_gallery/media_device_notification_window_win.cc:60:
&MediaDeviceNotificationWindowWin::WndProcThunk>;
On 2012/04/24 21:58:17, vandebo wrote:
> nit: four spaces

Done.

http://codereview.chromium.org/10211008/diff/1/chrome/browser/media_gallery/m...
chrome/browser/media_gallery/media_device_notification_window_win.cc:79: UINT
event_type, DWORD data) {
On 2012/04/24 21:58:17, vandebo wrote:
> nit: looks like the first arg will fit on the previous line.

Done.

http://codereview.chromium.org/10211008/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/10211008/diff/1/chrome/chrome_browser.gypi#new...
chrome/chrome_browser.gypi:1299:
'browser/media_gallery/media_device_notification_window_win.h',
On 2012/04/24 21:58:17, vandebo wrote:
> nit: probably should follow the existing name convention, plural notifications

Done.

[Lei Zhang, 2012-04-24 23:10:42]

http://codereview.chromium.org/10211008/diff/5001/chrome/browser/media_galler...
File chrome/browser/media_gallery/media_device_notifications_window_win.cc
(right):

http://codereview.chromium.org/10211008/diff/5001/chrome/browser/media_galler...
chrome/browser/media_gallery/media_device_notifications_window_win.cc:78: DWORD
data) {
nit: indentation

http://codereview.chromium.org/10211008/diff/5001/chrome/browser/media_galler...
File chrome/browser/media_gallery/media_device_notifications_window_win.h
(right):

http://codereview.chromium.org/10211008/diff/5001/chrome/browser/media_galler...
chrome/browser/media_gallery/media_device_notifications_window_win.h:22:
explicit MediaDeviceNotificationsWindowWin::MediaDeviceNotificationsWindowWin(
Do you need to write this as Foo::Foo(params) ?

http://codereview.chromium.org/10211008/diff/5001/chrome/browser/media_galler...
chrome/browser/media_gallery/media_device_notifications_window_win.h:39:
MediaDeviceNotificationsWindowWin* msg_wnd =
Would you mind moving the implementation to the .cc file?

http://codereview.chromium.org/10211008/diff/5001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/10211008/diff/5001/chrome/chrome_browser.gypi#...
chrome/chrome_browser.gypi:1298:
'browser/media_gallery/media_device_notifications_window_win.cc',
nit: l before w

http://codereview.chromium.org/10211008/diff/5001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/10211008/diff/5001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:1439:
'browser/media_gallery/media_device_notifications_window_win_unittest.cc',
nit: l before w

[tpayne, 2012-04-25 00:04:31]

http://codereview.chromium.org/10211008/diff/5001/chrome/browser/media_galler...
File chrome/browser/media_gallery/media_device_notifications_window_win.cc
(right):

http://codereview.chromium.org/10211008/diff/5001/chrome/browser/media_galler...
chrome/browser/media_gallery/media_device_notifications_window_win.cc:78: DWORD
data) {
On 2012/04/24 23:10:42, Lei Zhang wrote:
> nit: indentation

Done.

http://codereview.chromium.org/10211008/diff/5001/chrome/browser/media_galler...
File chrome/browser/media_gallery/media_device_notifications_window_win.h
(right):

http://codereview.chromium.org/10211008/diff/5001/chrome/browser/media_galler...
chrome/browser/media_gallery/media_device_notifications_window_win.h:22:
explicit MediaDeviceNotificationsWindowWin::MediaDeviceNotificationsWindowWin(
On 2012/04/24 23:10:42, Lei Zhang wrote:
> Do you need to write this as Foo::Foo(params) ?

Done.

http://codereview.chromium.org/10211008/diff/5001/chrome/browser/media_galler...
chrome/browser/media_gallery/media_device_notifications_window_win.h:39:
MediaDeviceNotificationsWindowWin* msg_wnd =
On 2012/04/24 23:10:42, Lei Zhang wrote:
> Would you mind moving the implementation to the .cc file?

Done.

http://codereview.chromium.org/10211008/diff/5001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/10211008/diff/5001/chrome/chrome_browser.gypi#...
chrome/chrome_browser.gypi:1298:
'browser/media_gallery/media_device_notifications_window_win.cc',
On 2012/04/24 23:10:42, Lei Zhang wrote:
> nit: l before w

Done.

http://codereview.chromium.org/10211008/diff/5001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/10211008/diff/5001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:1439:
'browser/media_gallery/media_device_notifications_window_win_unittest.cc',
On 2012/04/24 23:10:42, Lei Zhang wrote:
> nit: l before w

Done.

[Lei Zhang, 2012-04-25 00:21:45]

LGTM with some nits.

http://codereview.chromium.org/10211008/diff/11001/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_device_notifications_window_win.cc
(right):

http://codereview.chromium.org/10211008/diff/11001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_device_notifications_window_win.cc:121: 
Can you add a comment here?
// static

http://codereview.chromium.org/10211008/diff/11001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_device_notifications_window_win.cc:122:
LRESULT CALLBACK MediaDeviceNotificationsWindowWin::WndProcThunk(HWND hwnd,
nit: the arguments should line up.

[tpayne, 2012-04-25 00:23:20]

http://codereview.chromium.org/10211008/diff/11001/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_device_notifications_window_win.cc
(right):

http://codereview.chromium.org/10211008/diff/11001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_device_notifications_window_win.cc:121: 
On 2012/04/25 00:21:45, Lei Zhang wrote:
> Can you add a comment here?
> // static

Done.

http://codereview.chromium.org/10211008/diff/11001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_device_notifications_window_win.cc:122:
LRESULT CALLBACK MediaDeviceNotificationsWindowWin::WndProcThunk(HWND hwnd,
On 2012/04/25 00:21:45, Lei Zhang wrote:
> nit: the arguments should line up.

They can't. The final line would be 82 characters long.

[Lei Zhang, 2012-04-25 00:33:56]

http://codereview.chromium.org/10211008/diff/11001/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_device_notifications_window_win.cc
(right):

http://codereview.chromium.org/10211008/diff/11001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_device_notifications_window_win.cc:122:
LRESULT CALLBACK MediaDeviceNotificationsWindowWin::WndProcThunk(HWND hwnd,
On 2012/04/25 00:23:20, tpayne wrote:
> On 2012/04/25 00:21:45, Lei Zhang wrote:
> > nit: the arguments should line up.
> 
> They can't. The final line would be 82 characters long.

You can bring |hwnd| down to the next line. See last example in
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Calls

[tpayne, 2012-04-25 00:39:19]

http://codereview.chromium.org/10211008/diff/11001/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_device_notifications_window_win.cc
(right):

http://codereview.chromium.org/10211008/diff/11001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_device_notifications_window_win.cc:122:
LRESULT CALLBACK MediaDeviceNotificationsWindowWin::WndProcThunk(HWND hwnd,
On 2012/04/25 00:33:56, Lei Zhang wrote:
> On 2012/04/25 00:23:20, tpayne wrote:
> > On 2012/04/25 00:21:45, Lei Zhang wrote:
> > > nit: the arguments should line up.
> > 
> > They can't. The final line would be 82 characters long.
> 
> You can bring |hwnd| down to the next line. See last example in
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Calls

Done.

[jam, 2012-04-25 02:35:42]

lgtm, thanks

[commit-bot: I haz the power, 2012-04-25 16:57:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tpayne@chromium.org/10211008/1014

[commit-bot: I haz the power, 2012-04-25 18:35:12]

Change committed as 133946