sync: Loop committing items without downloading updates (v2)

sync/engine/get_commit_ids_command.h

Index: sync/engine/get_commit_ids_command.h
diff --git a/sync/engine/get_commit_ids_command.h b/sync/engine/get_commit_ids_command.h
index 334fb6b9d406fd8f8d87c62c41e3c8299ec65e48..8fa8a2773c0a81ab3b8875faa231ebbd2d829620 100644
--- a/sync/engine/get_commit_ids_command.h
+++ b/sync/engine/get_commit_ids_command.h
@@ -24,7 +24,9 @@ class GetCommitIdsCommand : public SyncerCommand {
   friend class SyncerTest;
 
  public:
-  explicit GetCommitIdsCommand(int commit_batch_size);
+  GetCommitIdsCommand(size_t commit_batch_size,
+                      sessions::OrderedCommitSet* ordered_commit_set,
+                      size_t* unsynced_item_count);

[tim (not reviewing), 2012/05/11 18:42:16]

Comments would be nice here.

[rlarocque, 2012/05/14 23:10:43]

Done.

   virtual ~GetCommitIdsCommand();
 
   // SyncerCommand implementation.
@@ -93,8 +95,7 @@ class GetCommitIdsCommand : public SyncerCommand {
                                sessions::OrderedCommitSet* result) const;
 
   // Appends all commit ready predecessors of |item|, followed by |item| itself,
-  // to |ordered_commit_set_|, iff item and all its predecessors not in
-  // conflict.
+  // to |commit_set|, iff item and all its predecessors not in conflict.
   // Return values:
   //   False: if there was an entry in conflict.
   //   True: if all entries were checked for commit readiness and added to
@@ -103,7 +104,7 @@ class GetCommitIdsCommand : public SyncerCommand {
                                const ModelSafeRoutingInfo& routes,
                                const std::set<int64>& ready_unsynced_set,
                                const syncable::Entry& item,
-                               sessions::OrderedCommitSet* result) const;
+                               sessions::OrderedCommitSet* commit_set) const;
 
   bool IsCommitBatchFull() const;
 
@@ -114,9 +115,9 @@ class GetCommitIdsCommand : public SyncerCommand {
   void AddDeletes(syncable::WriteTransaction* write_transaction,
                   const std::set<int64>& ready_unsynced_set);
 
-  scoped_ptr<sessions::OrderedCommitSet> ordered_commit_set_;
-
-  int requested_commit_batch_size_;
+  size_t requested_commit_batch_size_;

[tim (not reviewing), 2012/05/11 18:42:16]

const?

[rlarocque, 2012/05/14 23:10:43]

Done.

+  sessions::OrderedCommitSet* commit_set_;

[tim (not reviewing), 2012/05/11 18:42:16]

Comments about ownership / lifetime wouldn't hurt.

[rlarocque, 2012/05/14 23:10:43]

Done.

+  size_t* unsynced_item_count_;
 
   DISALLOW_COPY_AND_ASSIGN(GetCommitIdsCommand);
 };