sync: Loop committing items without downloading updates (v2)

sync/sessions/status_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/sessions/status_controller.h"
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "sync/protocol/sync_protocol_error.h"
@@ skipping 124 matching lines @@
 
 void StatusController::UpdateStartTime() {
   sync_start_time_ = base::Time::Now();
 }
 
 void StatusController::set_num_successful_bookmark_commits(int value) {
   if (shared_.syncer_status.value().num_successful_bookmark_commits != value)
     shared_.syncer_status.mutate()->num_successful_bookmark_commits = value;
 }
 
-void StatusController::set_unsynced_handles(
-    const std::vector<int64>& unsynced_handles) {
-  if (!operator==(unsynced_handles, shared_.unsynced_handles.value())) {
-    *(shared_.unsynced_handles.mutate()) = unsynced_handles;
-  }
-}
-
 void StatusController::increment_num_successful_bookmark_commits() {
   set_num_successful_bookmark_commits(
       shared_.syncer_status.value().num_successful_bookmark_commits + 1);
 }
 
 void StatusController::increment_num_successful_commits() {
   shared_.syncer_status.mutate()->num_successful_commits++;
 }
 
 void StatusController::increment_num_local_overwrites() {
@@ skipping 11 matching lines @@
 
 void StatusController::set_last_download_updates_result(
     const SyncerError result) {
   shared_.error.mutate()->last_download_updates_result = result;
 }
 
 void StatusController::set_last_post_commit_result(const SyncerError result) {
   shared_.error.mutate()->last_post_commit_result = result;
 }
 
+SyncerError StatusController::last_post_commit_result() const {
+  return shared_.error.value().last_post_commit_result;
+}
+
 void StatusController::set_last_process_commit_response_result(
     const SyncerError result) {
   shared_.error.mutate()->last_process_commit_response_result = result;
 }
 
-void StatusController::set_commit_set(const OrderedCommitSet& commit_set) {
-  DCHECK(!group_restriction_in_effect_);
-  shared_.commit_set = commit_set;
+SyncerError StatusController::last_process_commit_response_result() const {
+  return shared_.error.value().last_process_commit_response_result;
 }
 
 void StatusController::update_conflicts_resolved(bool resolved) {
   shared_.control_params.conflicts_resolved |= resolved;
 }
 void StatusController::reset_conflicts_resolved() {
   shared_.control_params.conflicts_resolved = false;
 }
-void StatusController::set_items_committed() {
-  shared_.control_params.items_committed = true;
-}
 
 // Returns the number of updates received from the sync server.
 int64 StatusController::CountUpdates() const {
   const ClientToServerResponse& updates = shared_.updates_response;
   if (updates.has_get_updates()) {
     return updates.get_updates().entries().size();
   } else {
     return 0;
   }
 }
 
-bool StatusController::CurrentCommitIdProjectionHasIndex(size_t index) {
-  OrderedCommitSet::Projection proj =
-      shared_.commit_set.GetCommitIdProjection(group_restriction_);
-  return std::binary_search(proj.begin(), proj.end(), index);
-}
-
 bool StatusController::HasConflictingUpdates() const {
   DCHECK(!group_restriction_in_effect_)
       << "HasConflictingUpdates applies to all ModelSafeGroups";
   std::map<ModelSafeGroup, PerModelSafeGroupState*>::const_iterator it =
     per_model_group_.begin();
   for (; it != per_model_group_.end(); ++it) {
     if (it->second->update_progress.HasConflictingUpdates())
       return true;
   }
   return false;
@@ skipping 78 matching lines @@
 void StatusController::set_debug_info_sent() {
   shared_.control_params.debug_info_sent = true;
 }
 
 bool StatusController::debug_info_sent() const {
   return shared_.control_params.debug_info_sent;
 }
 
 }  // namespace sessions
 }  // namespace browser_sync