Per bug 121738, ignore old saved logins for http*://www.google.com.

chrome/browser/password_manager/password_store_default_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
-#include "base/scoped_temp_dir.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/password_manager/password_form_data.h"
 #include "chrome/browser/password_manager/password_store_change.h"
 #include "chrome/browser/password_manager/password_store_consumer.h"
 #include "chrome/browser/password_manager/password_store_default.h"
 #include "chrome/browser/prefs/pref_service.h"
@@ skipping 17 matching lines @@
 using testing::Property;
 using testing::WithArg;
 using webkit::forms::PasswordForm;
 
 namespace {
 
 class MockPasswordStoreConsumer : public PasswordStoreConsumer {
  public:
   MOCK_METHOD2(OnPasswordStoreRequestDone,
                void(CancelableRequestProvider::Handle,
-                    const std::vector<webkit::forms::PasswordForm*>&));
+                    const std::vector<PasswordForm*>&));
 };
 
 // This class will add and remove a mock notification observer from
 // the DB thread.
-class DBThreadObserverHelper :
-    public base::RefCountedThreadSafe<DBThreadObserverHelper,
-                                      BrowserThread::DeleteOnDBThread> {
+class DBThreadObserverHelper
+    : public base::RefCountedThreadSafe<DBThreadObserverHelper,
+                                        BrowserThread::DeleteOnDBThread> {
  public:
   DBThreadObserverHelper() : done_event_(true, false) {}
 
   void Init(PasswordStore* password_store) {
     DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
     BrowserThread::PostTask(
         BrowserThread::DB,
         FROM_HERE,
         base::Bind(&DBThreadObserverHelper::AddObserverTask,
                    this,
@@ skipping 21 matching lines @@
     done_event_.Signal();
   }
 
   WaitableEvent done_event_;
   content::NotificationRegistrar registrar_;
   content::NotificationObserverMock observer_;
 };
 
 }  // anonymous namespace
 
-typedef std::vector<PasswordForm*> VectorOfForms;
-
 class PasswordStoreDefaultTest : public testing::Test {
  protected:
   PasswordStoreDefaultTest()
       : ui_thread_(BrowserThread::UI, &message_loop_),
         db_thread_(BrowserThread::DB) {
   }
 
   virtual void SetUp() {
     ASSERT_TRUE(db_thread_.Start());
-    ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
 
     profile_.reset(new TestingProfile());
 
     login_db_.reset(new LoginDatabase());
-    ASSERT_TRUE(login_db_->Init(temp_dir_.path().Append(
+    ASSERT_TRUE(login_db_->Init(profile_->GetPath().Append(
         FILE_PATH_LITERAL("login_test"))));
   }
 
   virtual void TearDown() {
     MessageLoop::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());
     MessageLoop::current()->Run();
     db_thread_.Stop();
   }
 
   MessageLoopForUI message_loop_;
   content::TestBrowserThread ui_thread_;
   // PasswordStore, WDS schedule work on this thread.
   content::TestBrowserThread db_thread_;
 
   scoped_ptr<LoginDatabase> login_db_;
   scoped_ptr<TestingProfile> profile_;
-  ScopedTempDir temp_dir_;
 };
 
 ACTION(STLDeleteElements0) {
   STLDeleteContainerPointers(arg0.begin(), arg0.end());
 }
 
 ACTION(QuitUIMessageLoop) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   MessageLoop::current()->Quit();
 }
 
 TEST_F(PasswordStoreDefaultTest, NonASCIIData) {
   scoped_refptr<PasswordStoreDefault> store(
       new PasswordStoreDefault(login_db_.release(), profile_.get()));
   store->Init();
 
   // Some non-ASCII password form data.
-  PasswordFormData form_data[] = {
+  static const PasswordFormData form_data[] = {
     { PasswordForm::SCHEME_HTML,
       "http://foo.example.com",
       "http://foo.example.com/origin",
       "http://foo.example.com/action",
       L"มีสีสัน",
       L"お元気ですか?",
       L"盆栽",
       L"أحب كرة",
       L"£éä국수çà",
       true, false, 1 },
   };
 
   // Build the expected forms vector and add the forms to the store.
-  VectorOfForms expected_forms;
+  std::vector<PasswordForm*> expected_forms;
   for (unsigned int i = 0; i < ARRAYSIZE_UNSAFE(form_data); ++i) {
     PasswordForm* form = CreatePasswordFormFromData(form_data[i]);
     expected_forms.push_back(form);
     store->AddLogin(*form);
   }
 
   // The PasswordStore schedules tasks to run on the DB thread so we schedule
   // yet another task to notify us that it's safe to carry on with the test.
+  // The PasswordStore doesn't really understand that it's "done" once the tasks
+  // we posted above have completed, so there's no formal notification for that.
   WaitableEvent done(false, false);
   BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,
       base::Bind(&WaitableEvent::Signal, base::Unretained(&done)));
   done.Wait();
 
   MockPasswordStoreConsumer consumer;
 
   // Make sure we quit the MessageLoop even if the test fails.
   ON_CALL(consumer, OnPasswordStoreRequestDone(_, _))
       .WillByDefault(QuitUIMessageLoop());
@@ skipping 88 matching lines @@
   // Deleting the login should trigger a notification.
   store->RemoveLogin(*form);
 
   // Wait for PasswordStore to send the notification.
   BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,
       base::Bind(&WaitableEvent::Signal, base::Unretained(&done)));
   done.Wait();
 
   store->ShutdownOnUIThread();
 }