Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Issue 10209022: Refactor media stream infobar delegate code and also fix a typo (Closed)

Created:
8 years, 8 months ago by Jeremy Mao
Modified:
8 years, 8 months ago
CC:
chromium-reviews, robertshield, kkania, Peter Kasting
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Refactor media stream infobar delegate code and also fix a typo BUG=NONE TEST=ui_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -24 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/infobars/infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/infobars/infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/media_stream_infobar_gtk.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/media_stream_infobar_gtk.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/ui/media_stream_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/media_stream_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/media_stream_infobar.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/media_stream_infobar.cc View 4 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jeremy Mao
Hi all, Could you please take a look at this when you are free? Thanks ...
8 years, 8 months ago (2012-04-27 06:24:39 UTC) #1
sky
LGTM
8 years, 8 months ago (2012-04-27 15:50:28 UTC) #2
Jeremy Mao
8 years, 8 months ago (2012-04-27 23:48:52 UTC) #3
Evan Stade
gtk lgtm
8 years, 8 months ago (2012-04-28 00:35:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yujie.mao@intel.com/10209022/1
8 years, 8 months ago (2012-04-28 02:25:39 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-28 03:47:55 UTC) #6
Change committed as 134440

Powered by Google App Engine
This is Rietveld 408576698