Make functions being routed by NativeHandlers throw an exception if there is no ModuleSystem in the…

Make functions being routed by NativeHandlers throw an exception if there is no ModuleSystem in the current context.


BUG=124208
TEST=existing tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133643

[not at google - send to devlin, 2012-04-24 05:15:29]

lgtm

https://chromiumcodereview.appspot.com/10208001/diff/2001/chrome/renderer/nat...
File chrome/renderer/native_handler.cc (right):

https://chromiumcodereview.appspot.com/10208001/diff/2001/chrome/renderer/nat...
chrome/renderer/native_handler.cc:31: v8::String::New("ModuleSystem has been
deleted")));
nit: braces around multi-line-single-statement if statements.

it also seems.. better.. for this to be the first thing that runs in this
method, rather than after grabbing the handler function. And... also a comment
why the check is necessary would be nice.

[koz (OOO until 15th September), 2012-04-24 05:35:20]

Cheers.

https://chromiumcodereview.appspot.com/10208001/diff/2001/chrome/renderer/nat...
File chrome/renderer/native_handler.cc (right):

https://chromiumcodereview.appspot.com/10208001/diff/2001/chrome/renderer/nat...
chrome/renderer/native_handler.cc:31: v8::String::New("ModuleSystem has been
deleted")));
On 2012/04/24 05:15:29, kalman wrote:
> nit: braces around multi-line-single-statement if statements.
> 
> it also seems.. better.. for this to be the first thing that runs in this
> method, rather than after grabbing the handler function. And... also a comment
> why the check is necessary would be nice.

Done.

[commit-bot: I haz the power, 2012-04-24 05:35:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/10208001/7001

[commit-bot: I haz the power, 2012-04-24 07:24:53]

Change committed as 133643