gdata: Simplify InitiateUpload() and ResumeUpload()

gdata: Simplify InitiateUpload() and ResumeUpload()

These are called on UI thread, so no need to deal with
MesageLoopProxy::current() etc.

BUG=chromium-os:29036, chromium-os:29943
TEST=saving to gdata works as before and no error was emitted with --enable-dcheck with a Release build.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133817

[achuithb, 2012-04-24 23:46:14]

http://codereview.chromium.org/10207022/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10207022/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:1898:
MessageLoop::current()->PostTask(
Is there a reason to PostTask here instead of running the callback?

http://codereview.chromium.org/10207022/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

http://codereview.chromium.org/10207022/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.h:590: void InitiateUpload(const
std::string& file_name,
Could you also please add a TODO to remove these pass through functions
entirely?

[satorux1, 2012-04-24 23:54:19]

http://codereview.chromium.org/10207022/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10207022/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:1898:
MessageLoop::current()->PostTask(
On 2012/04/24 23:46:14, achuith.bhandarkar wrote:
> Is there a reason to PostTask here instead of running the callback?

In async functions, we usually run a callback through the message loop as the
caller may not expect that the callback is called immediately. I think this
convention is to be just extra defensive.

http://codereview.chromium.org/10207022/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

http://codereview.chromium.org/10207022/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.h:590: void InitiateUpload(const
std::string& file_name,
On 2012/04/24 23:46:14, achuith.bhandarkar wrote:
> Could you also please add a TODO to remove these pass through functions
> entirely?

Done.

[achuithb, 2012-04-24 23:55:27]

lgtm