Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 10207006: Move CellularDataPlanInfo to CellularDataPlan conversion code to cros_network_functions.cc (Closed)

Created:
8 years, 8 months ago by hashimoto
Modified:
8 years, 8 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move CellularDataPlanInfo to CellularDataPlan conversion code to cros_network_functions.cc Move CellularDataPlan from network_library.* to its own files. Move CellularDataInfo to CellularData conversion code to cros_network_functions.cc BUG=chromium-os:16557 TEST=unit_tests --gtest_filter="CrosNetworkFunctionsLibcrosTest.CrosMonitorCellularDataPlan" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133918

Patch Set 1 : _ #

Patch Set 2 : Rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -230 lines) Patch
A chrome/browser/chromeos/cros/cellular_data_plan.h View 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/cros/cellular_data_plan.cc View 1 chunk +165 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_network_functions.h View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros/cros_network_functions.cc View 1 2 2 chunks +28 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_network_functions_unittest.cc View 1 2 3 chunks +81 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 4 chunks +0 lines, -51 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 2 chunks +0 lines, -141 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_cros.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_cros.cc View 2 chunks +4 lines, -19 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
8 years, 8 months ago (2012-04-24 06:34:04 UTC) #1
stevenjb
lgtm
8 years, 8 months ago (2012-04-25 01:40:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10207006/1011
8 years, 8 months ago (2012-04-25 12:33:54 UTC) #3
commit-bot: I haz the power
Can't apply patch for file chrome/browser/chromeos/cros/cros_network_functions_unittest.cc. While running patch -p1 --forward --force; patching file chrome/browser/chromeos/cros/cros_network_functions_unittest.cc ...
8 years, 8 months ago (2012-04-25 12:33:58 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 15:20:36 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698