Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2379)

Unified Diff: chrome/browser/net/network_stats_unittest.cc

Issue 10206035: NetConnectivity - Collect stats for TCP/UDP network (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/net/network_stats.cc ('K') | « chrome/browser/net/network_stats.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/network_stats_unittest.cc
===================================================================
--- chrome/browser/net/network_stats_unittest.cc (revision 135283)
+++ chrome/browser/net/network_stats_unittest.cc (working copy)
@@ -36,7 +36,7 @@
}
protected:
- void RunUDPEchoTest(int bytes, int packets) {
+ void RunUDPEchoTest(int bytes, int packets, bool has_proxy) {
net::TestCompletionCallback cb;
scoped_ptr<net::MockHostResolver> host_resolver(
@@ -48,6 +48,7 @@
EXPECT_TRUE(udp_stats_client->Start(host_resolver.get(),
test_server_.host_port_pair(),
NetworkStats::HISTOGRAM_PORT_MAX,
+ has_proxy,
bytes,
packets,
cb.callback()));
@@ -68,7 +69,7 @@
}
protected:
- void RunTCPEchoTest(int bytes, int packets) {
+ void RunTCPEchoTest(int bytes, int packets, bool has_proxy) {
net::TestCompletionCallback cb;
scoped_ptr<net::MockHostResolver> host_resolver(
@@ -80,6 +81,7 @@
EXPECT_TRUE(tcp_stats_client->Start(host_resolver.get(),
test_server_.host_port_pair(),
NetworkStats::HISTOGRAM_PORT_MAX,
+ has_proxy,
bytes,
packets,
cb.callback()));
@@ -91,31 +93,56 @@
net::TestServer test_server_;
};
-TEST_F(NetworkStatsTestUDP, UDPEcho_100B_Of_Data) {
+TEST_F(NetworkStatsTestUDP, UDPEcho100BytesHasProxy) {
ASSERT_TRUE(test_server_.Start());
- RunUDPEchoTest(100, 1);
+ RunUDPEchoTest(100, 1, true);
}
-TEST_F(NetworkStatsTestUDP, UDPEcho_1K_Of_Data) {
+TEST_F(NetworkStatsTestUDP, UDPEcho100BytesNoProxy) {
ASSERT_TRUE(test_server_.Start());
- RunUDPEchoTest(1024, 1);
+ RunUDPEchoTest(100, 1, false);
}
-TEST_F(NetworkStatsTestUDP, UDPEchoMultiplePackets) {
+TEST_F(NetworkStatsTestUDP, UDPEcho1KBytesHasProxy) {
ASSERT_TRUE(test_server_.Start());
- RunUDPEchoTest(1024, 4);
+ RunUDPEchoTest(1024, 1, true);
}
-TEST_F(NetworkStatsTestTCP, TCPEcho_100B_Of_Data) {
+TEST_F(NetworkStatsTestUDP, UDPEcho1KBytesNoProxy) {
ASSERT_TRUE(test_server_.Start());
- RunTCPEchoTest(100, 1);
+ RunUDPEchoTest(1024, 1, false);
}
-TEST_F(NetworkStatsTestTCP, TCPEcho_1K_Of_Data) {
+TEST_F(NetworkStatsTestUDP, UDPEchoMultiplePacketsHasProxy) {
ASSERT_TRUE(test_server_.Start());
- RunTCPEchoTest(1024, 1);
+ RunUDPEchoTest(1024, 4, true);
}
+TEST_F(NetworkStatsTestUDP, UDPEchoMultiplePacketsNoProxy) {
+ ASSERT_TRUE(test_server_.Start());
+ RunUDPEchoTest(1024, 4, false);
+}
+
+TEST_F(NetworkStatsTestTCP, TCPEcho100BytesHasProxy) {
+ ASSERT_TRUE(test_server_.Start());
+ RunTCPEchoTest(100, 1, true);
+}
+
+TEST_F(NetworkStatsTestTCP, TCPEcho100BytesNoProxy) {
+ ASSERT_TRUE(test_server_.Start());
+ RunTCPEchoTest(100, 1, false);
+}
+
+TEST_F(NetworkStatsTestTCP, TCPEcho1KBytesHasProxy) {
+ ASSERT_TRUE(test_server_.Start());
+ RunTCPEchoTest(1024, 1, true);
+}
+
+TEST_F(NetworkStatsTestTCP, TCPEcho1KBytesNoProxy) {
+ ASSERT_TRUE(test_server_.Start());
+ RunTCPEchoTest(1024, 1, false);
+}
+
TEST_F(NetworkStatsTestTCP, VerifyBytes) {
static const uint32 KBytesToSend = 100;
static const uint32 packets_to_send = 1;
@@ -124,6 +151,7 @@
net::TestCompletionCallback cb;
network_stats.Initialize(KBytesToSend,
NetworkStats::HISTOGRAM_PORT_MAX,
+ true,
packets_to_send,
cb.callback());
« chrome/browser/net/network_stats.cc ('K') | « chrome/browser/net/network_stats.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698