JSON schema compiler can't handle strings as types

tools/json_schema_compiler/compiler.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Generator for C++ structs from api json files.
 
 The purpose of this tool is to remove the need for hand-written code that
 converts to and from base::Value types when receiving javascript api calls.
 Originally written for generating code for extension apis. Reference schemas
 are in chrome/common/extensions/api.
@@ skipping 60 matching lines @@
     # The output filename must match the input filename for gyp to deal with it
     # properly.
     out_file = namespace.name
     type_generator = cpp_type_generator.CppTypeGenerator(
         root_namespace, namespace, namespace.unix_name)
     for referenced_namespace in api_model.namespaces.values():
       if referenced_namespace == namespace:
         continue
       type_generator.AddNamespace(
           referenced_namespace,
-          referenced_namespace.unix_name)
+          referenced_namespace.name)

[cduvall, 2012/04/27 22:28:52]

This should be |name| because the files are saved in the form
fileName.h, not file_name.h.

[Yoyo Zhou, 2012/05/01 00:21:58]

This is a tangent, but it's a bummer that there are no tests for this... I've
seen fileName in enough places to know that it's what the generated filenames
look like, but you might check with kalman to see if this was the intention.

[cduvall, 2012/05/01 00:31:51]

Yeah, it is too bad that fileName has been used. It seems like file_name would
be better for style. I'll ask kalman about it and maybe address it in a separate
bug depending on what he says.

[cduvall, 2012/05/01 00:48:54]

Just talked to kalman, he wants the files to be named like "file_name". I'm
going to get this one committed first and then change this back after I finish
the bug for changing the filenames. Here's the bug: http://crbug.com/125669

 
     h_code = (h_generator.HGenerator(namespace, type_generator)
         .Generate().Render())
     cc_code = (cc_generator.CCGenerator(namespace, type_generator)
         .Generate().Render())
 
     if dest_dir:
       with open(
           os.path.join(dest_dir, namespace.source_file_dir, out_file + '.cc'),
           'w') as cc_file:
@@ skipping 21 matching lines @@
 
   api_model = model.Model()
   relpath = os.path.relpath(os.path.normpath(filenames[0]), root)
   for target_namespace in api_defs:
     api_model.AddNamespace(target_namespace, relpath)
 
   type_generator = cpp_type_generator.CppTypeGenerator(root_namespace)
   for referenced_namespace in api_model.namespaces.values():
     type_generator.AddNamespace(
         referenced_namespace,
-        referenced_namespace.unix_name)
+        referenced_namespace.name)
 
   generator = schema_bundle_generator.SchemaBundleGenerator(
       api_model, api_defs, type_generator)
   api_h_code = generator.GenerateAPIHeader().Render()
   schemas_h_code = generator.GenerateSchemasHeader().Render()
   schemas_cc_code = generator.GenerateSchemasCC().Render()
 
   if dest_dir:
     basedir = os.path.join(dest_dir, 'chrome/common/extensions/api')
     with open(os.path.join(basedir, 'generated_api.h'), 'w') as h_file:
@@ skipping 34 matching lines @@
 
   if not args:
     sys.exit(0) # This is OK as a no-op
   dest_dir = opts.destdir
   root_namespace = opts.namespace
 
   if opts.bundle:
     handle_bundle_schema(args, dest_dir, opts.root, root_namespace)
   else:
     handle_single_schema(args[0], dest_dir, opts.root, root_namespace)