Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 10206010: Add missing .exe extension to yasm binary path on Windows (Closed)

Created:
8 years, 8 months ago by scottmg
Modified:
8 years, 7 months ago
Reviewers:
Nico, Alpha Left Google
CC:
chromium-reviews
Visibility:
Public.

Description

Add missing .exe extension to yasm binary path on Windows Avoids spurious rebuilds when building with ninja on Windows, as it's expecting "yasm" to exist, rather than "yasm.exe". In VS, the dependency check happens to work because there's a directory named "yasm" parallel to yasm.exe which it seems to accept. Also fix minor typo in compile message. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/yasm/yasm_compile.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
8 years, 8 months ago (2012-04-24 03:37:06 UTC) #1
Nico
lgtm
8 years, 8 months ago (2012-04-27 23:22:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10206010/1
8 years, 7 months ago (2012-04-30 18:15:13 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-04-30 21:14:54 UTC) #4
Change committed as 134599

Powered by Google App Engine
This is Rietveld 408576698