Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Side by Side Diff: build/precompile.h

Issue 10204018: Change a couple of TODOs to plain comments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Precompiled header for Chromium project on Windows, not used by 5 // Precompiled header for Chromium project on Windows, not used by
6 // other build configurations. Using precompiled headers speeds the 6 // other build configurations. Using precompiled headers speeds the
7 // build up significantly, around 1/4th on VS 2010 on an HP Z600 with 12 7 // build up significantly, around 1/4th on VS 2010 on an HP Z600 with 12
8 // GB of memory. 8 // GB of memory.
9 // 9 //
10 // Numeric comments beside includes are the number of times they were 10 // Numeric comments beside includes are the number of times they were
11 // included under src/chrome/browser on 2011/8/20, which was used as a 11 // included under src/chrome/browser on 2011/8/20, which was used as a
12 // baseline for deciding what to include in the PCH. It may be 12 // baseline for deciding what to include in the PCH. Includes without
13 // possible to tweak the speed of the build by commenting out or 13 // a numeric comment are generally included at least 5 times. It may
14 // be possible to tweak the speed of the build by commenting out or
14 // removing some of the less frequently used headers. 15 // removing some of the less frequently used headers.
15 16
16 #if defined(BUILD_PRECOMPILE_H_) 17 #if defined(BUILD_PRECOMPILE_H_)
17 #error You shouldn't include the precompiled header file more than once. 18 #error You shouldn't include the precompiled header file more than once.
18 #endif 19 #endif
19 20
20 #define BUILD_PRECOMPILE_H_ 21 #define BUILD_PRECOMPILE_H_
21 22
22 // The Windows header needs to come before almost all the other 23 // The Windows header needs to come before almost all the other
23 // Windows-specific headers. 24 // Windows-specific headers.
24 #include <Windows.h> 25 #include <Windows.h>
25 #include <dwmapi.h> 26 #include <dwmapi.h>
26 #include <shellapi.h> 27 #include <shellapi.h>
27 #include <wincrypt.h> // 4 28 #include <wincrypt.h> // 4
28 #include <wtypes.h> // 2 29 #include <wtypes.h> // 2
29 30
30 // TODO(joi): Defines in atlbase.h cause conflicts; need to figure out 31 // Defines in atlbase.h cause conflicts; if we could figure out how
31 // if/how this family of headers can be included in the PCH; several 32 // this family of headers can be included in the PCH, it might speed
32 // of them are used quite frequently. 33 // up the build as several of them are used frequently.
33 /* 34 /*
34 #include <atlbase.h> 35 #include <atlbase.h>
35 #include <atlapp.h> 36 #include <atlapp.h>
36 #include <atlcom.h> 37 #include <atlcom.h>
37 #include <atlcrack.h> // 2 38 #include <atlcrack.h> // 2
38 #include <atlctrls.h> // 2 39 #include <atlctrls.h> // 2
39 #include <atlmisc.h> // 2 40 #include <atlmisc.h> // 2
40 #include <atlsafe.h> // 1 41 #include <atlsafe.h> // 1
41 #include <atltheme.h> // 1 42 #include <atltheme.h> // 1
42 #include <atlwin.h> // 2 43 #include <atlwin.h> // 2
43 */ 44 */
44 45
45 // TODO(joi): Objbase.h and other files that rely on it bring in 46 // Objbase.h and other files that rely on it bring in [ #define
46 // [ #define interface struct ] which can cause problems in a 47 // interface struct ] which can cause problems in a multi-platform
47 // multi-platform build like Chrome's. Tried #undef-ing it, but 48 // build like Chrome's. #undef-ing it does not work as there are
48 // there are currently 118 targets that break if we do this, so 49 // currently 118 targets that break if we do this, so leaving out of
49 // leaving out of the precompiled header for now. 50 // the precompiled header for now.
50 //#include <commctrl.h> // 2 51 //#include <commctrl.h> // 2
51 //#include <commdlg.h> // 3 52 //#include <commdlg.h> // 3
52 //#include <cryptuiapi.h> // 2 53 //#include <cryptuiapi.h> // 2
53 //#include <Objbase.h> // 2 54 //#include <Objbase.h> // 2
54 //#include <objidl.h> // 1 55 //#include <objidl.h> // 1
55 //#include <ole2.h> // 1 56 //#include <ole2.h> // 1
56 //#include <oleacc.h> // 2 57 //#include <oleacc.h> // 2
57 //#include <oleauto.h> // 1 58 //#include <oleauto.h> // 1
58 //#include <oleidl.h> // 1 59 //#include <oleidl.h> // 1
59 //#include <propkey.h> // 2 60 //#include <propkey.h> // 2
60 //#include <propvarutil.h> // 2 61 //#include <propvarutil.h> // 2
61 //#include <pstore.h> // 2 62 //#include <pstore.h> // 2
62 //#include <shlguid.h> // 1 63 //#include <shlguid.h> // 1
63 //#include <shlwapi.h> // 1 64 //#include <shlwapi.h> // 1
64 //#include <shobjidl.h> // 4 65 //#include <shobjidl.h> // 4
65 //#include <urlhist.h> // 2 66 //#include <urlhist.h> // 2
66 67
67 // TODO(joi): Caused other conflicts in addition to the 'interface' issue 68 // Caused other conflicts in addition to the 'interface' issue above.
68 // above, see if they can be resolved. 69 // #include <shlobj.h>
69 //#include <shlobj.h>
70 70
71 #include <errno.h> 71 #include <errno.h>
72 #include <fcntl.h> 72 #include <fcntl.h>
73 #include <limits.h> // 4 73 #include <limits.h> // 4
74 #include <math.h> 74 #include <math.h>
75 #include <memory.h> // 1 75 #include <memory.h> // 1
76 #include <signal.h> 76 #include <signal.h>
77 #include <stdarg.h> // 1 77 #include <stdarg.h> // 1
78 #include <stddef.h> 78 #include <stddef.h>
79 #include <stdio.h> 79 #include <stdio.h>
(...skipping 19 matching lines...) Expand all
99 #include <map> 99 #include <map>
100 #include <numeric> // 2 100 #include <numeric> // 2
101 #include <ostream> 101 #include <ostream>
102 #include <queue> 102 #include <queue>
103 #include <set> 103 #include <set>
104 #include <sstream> 104 #include <sstream>
105 #include <stack> 105 #include <stack>
106 #include <string> 106 #include <string>
107 #include <utility> 107 #include <utility>
108 #include <vector> 108 #include <vector>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698