Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10204017: Throttle updates to the internet details page. (Closed)

Created:
8 years, 8 months ago by kevers
Modified:
8 years, 8 months ago
Reviewers:
csilv
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Throttle updates to the internet details page. BUG=124738 TEST=Manual. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133923

Patch Set 1 #

Patch Set 2 : Fix handling of initial update request. #

Total comments: 2

Patch Set 3 : Add @const. #

Patch Set 4 : Merge with trunk. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M chrome/browser/resources/options2/chromeos/internet_detail.js View 1 2 3 3 chunks +50 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kevers
Hi Chris, Can you please have a look at this CL, which addresses a performance ...
8 years, 8 months ago (2012-04-24 15:18:33 UTC) #1
csilv
lgtm http://codereview.chromium.org/10204017/diff/2001/chrome/browser/resources/options2/chromeos/internet_detail.js File chrome/browser/resources/options2/chromeos/internet_detail.js (right): http://codereview.chromium.org/10204017/diff/2001/chrome/browser/resources/options2/chromeos/internet_detail.js#newcode15 chrome/browser/resources/options2/chromeos/internet_detail.js:15: var minimumUpdateContentsDelay_ = 50; /** @const */
8 years, 8 months ago (2012-04-24 22:00:53 UTC) #2
kevers
http://codereview.chromium.org/10204017/diff/2001/chrome/browser/resources/options2/chromeos/internet_detail.js File chrome/browser/resources/options2/chromeos/internet_detail.js (right): http://codereview.chromium.org/10204017/diff/2001/chrome/browser/resources/options2/chromeos/internet_detail.js#newcode15 chrome/browser/resources/options2/chromeos/internet_detail.js:15: var minimumUpdateContentsDelay_ = 50; On 2012/04/24 22:00:53, csilv wrote: ...
8 years, 8 months ago (2012-04-24 22:20:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/10204017/9001
8 years, 8 months ago (2012-04-25 14:38:02 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 16:08:51 UTC) #5 
Change committed as 133923

Powered by Google App Engine
This is Rietveld 408576698