Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: ui/views/widget/widget_unittest.cc

Issue 10204014: views: Make sure the bubble-delegate removes itself from the anchor-widget's observer list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/views/bubble/bubble_delegate.cc ('K') | « ui/views/bubble/bubble_delegate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget_unittest.cc
diff --git a/ui/views/widget/widget_unittest.cc b/ui/views/widget/widget_unittest.cc
index c1dbca0500e64542946c897a6b5bdf523ef8f02c..b0d0c3b8d596b3af7fcbf9f65e07890df6226c69 100644
--- a/ui/views/widget/widget_unittest.cc
+++ b/ui/views/widget/widget_unittest.cc
@@ -8,6 +8,7 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/gfx/point.h"
+#include "ui/views/bubble/bubble_delegate.h"
#include "ui/views/test/test_views_delegate.h"
#include "ui/views/test/views_test_base.h"
#include "ui/views/views_delegate.h"
@@ -738,6 +739,22 @@ TEST_F(WidgetObserverTest, DISABLED_VisibilityChange) {
toplevel->CloseNow();
}
+TEST_F(WidgetObserverTest, DestroyBubble) {
+ Widget* anchor = CreateTopLevelPlatformWidget();
+ View* view = new View;
+ anchor->SetContentsView(view);
+ anchor->Show();
+
+ BubbleDelegateView* bubble_delegate =
+ new BubbleDelegateView(view, BubbleBorder::NONE);
+ Widget* bubble_widget(BubbleDelegateView::CreateBubble(bubble_delegate));
+ bubble_widget->Show();
+ bubble_widget->CloseNow();
+
+ anchor->Hide();
+ anchor->CloseNow();
+}
+
#if !defined(USE_AURA) && defined(OS_WIN)
// Aura needs shell to maximize/fullscreen window.
// NativeWidgetGtk doesn't implement GetRestoredBounds.
« ui/views/bubble/bubble_delegate.cc ('K') | « ui/views/bubble/bubble_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698