views: Make sure the bubble-delegate removes itself from the anchor-widget's observer list.

ui/views/bubble/bubble_delegate.cc

Index: ui/views/bubble/bubble_delegate.cc
diff --git a/ui/views/bubble/bubble_delegate.cc b/ui/views/bubble/bubble_delegate.cc
index f593a1b23e21fe762c086a2ce229c8f447b0181f..5d7abc0a3afc527ab0edc76ac7cf6eb8cd08db08 100644
--- a/ui/views/bubble/bubble_delegate.cc
+++ b/ui/views/bubble/bubble_delegate.cc
@@ -138,7 +138,10 @@ BubbleDelegateView::BubbleDelegateView(
   AddAccelerator(ui::Accelerator(ui::VKEY_ESCAPE, 0));
 }
 
-BubbleDelegateView::~BubbleDelegateView() {}
+BubbleDelegateView::~BubbleDelegateView() {
+  if (anchor_widget_)
+    anchor_widget_->RemoveObserver(this);

[msw, 2012/04/24 14:49:06]

Try OnWidgetClosing, but even then, I find this is extremely hard to get right.

[sadrul, 2012/04/24 15:15:53]

I am not sure I understand what you mean.

[msw, 2012/04/24 17:01:43]

Sorry, I meant to say try putting this in a WidgetDelegate::WindowClosing
override; I've had problems doing this type of work in the dtor before.

That said, if you don't see issues, this may be okay.

[sadrul, 2012/04/24 18:00:49]

Done.

+}
 
 // static
 Widget* BubbleDelegateView::CreateBubble(BubbleDelegateView* bubble_delegate) {