Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: ui/views/bubble/bubble_delegate.h

Issue 10204014: views: Make sure the bubble-delegate removes itself from the anchor-widget's observer list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | ui/views/bubble/bubble_delegate.cc » ('j') | ui/views/bubble/bubble_delegate.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_ 5 #ifndef UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_
6 #define UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_ 6 #define UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/gtest_prod_util.h" 9 #include "base/gtest_prod_util.h"
10 #include "ui/base/animation/animation_delegate.h" 10 #include "ui/base/animation/animation_delegate.h"
(...skipping 24 matching lines...) Expand all
35 BubbleDelegateView(View* anchor_view, 35 BubbleDelegateView(View* anchor_view,
36 BubbleBorder::ArrowLocation arrow_location); 36 BubbleBorder::ArrowLocation arrow_location);
37 virtual ~BubbleDelegateView(); 37 virtual ~BubbleDelegateView();
38 38
39 // Create and initialize the bubble Widget(s) with proper bounds. 39 // Create and initialize the bubble Widget(s) with proper bounds.
40 static Widget* CreateBubble(BubbleDelegateView* bubble_delegate); 40 static Widget* CreateBubble(BubbleDelegateView* bubble_delegate);
41 41
42 // WidgetDelegate overrides: 42 // WidgetDelegate overrides:
43 virtual View* GetInitiallyFocusedView() OVERRIDE; 43 virtual View* GetInitiallyFocusedView() OVERRIDE;
44 virtual BubbleDelegateView* AsBubbleDelegate() OVERRIDE; 44 virtual BubbleDelegateView* AsBubbleDelegate() OVERRIDE;
45 virtual void WindowClosing() OVERRIDE;
45 virtual View* GetContentsView() OVERRIDE; 46 virtual View* GetContentsView() OVERRIDE;
46 virtual NonClientFrameView* CreateNonClientFrameView( 47 virtual NonClientFrameView* CreateNonClientFrameView(
47 views::Widget* widget) OVERRIDE; 48 views::Widget* widget) OVERRIDE;
48 49
49 // Widget::Observer overrides: 50 // Widget::Observer overrides:
50 virtual void OnWidgetClosing(Widget* widget) OVERRIDE; 51 virtual void OnWidgetClosing(Widget* widget) OVERRIDE;
51 virtual void OnWidgetVisibilityChanged(Widget* widget, bool visible) OVERRIDE; 52 virtual void OnWidgetVisibilityChanged(Widget* widget, bool visible) OVERRIDE;
52 virtual void OnWidgetActivationChanged(Widget* widget, bool active) OVERRIDE; 53 virtual void OnWidgetActivationChanged(Widget* widget, bool active) OVERRIDE;
53 virtual void OnWidgetMoved(Widget* widget) OVERRIDE; 54 virtual void OnWidgetMoved(Widget* widget) OVERRIDE;
54 55
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 172
172 // Parent native window of the bubble. 173 // Parent native window of the bubble.
173 gfx::NativeView parent_window_; 174 gfx::NativeView parent_window_;
174 175
175 DISALLOW_COPY_AND_ASSIGN(BubbleDelegateView); 176 DISALLOW_COPY_AND_ASSIGN(BubbleDelegateView);
176 }; 177 };
177 178
178 } // namespace views 179 } // namespace views
179 180
180 #endif // UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_ 181 #endif // UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_
OLDNEW
« no previous file with comments | « no previous file | ui/views/bubble/bubble_delegate.cc » ('j') | ui/views/bubble/bubble_delegate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698