views: Make sure the bubble-delegate removes itself from the anchor-widget's observer list.

ui/views/bubble/bubble_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/bubble/bubble_delegate.h"
 
 #include "ui/base/animation/slide_animation.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/views/bubble/bubble_frame_view.h"
 #include "ui/views/widget/widget.h"
@@ skipping 145 matching lines @@
 
   bubble_delegate->SizeToContents();
   bubble_widget->AddObserver(bubble_delegate);
   return bubble_widget;
 }
 
 View* BubbleDelegateView::GetInitiallyFocusedView() {
   return this;
 }
 
+void BubbleDelegateView::WindowClosing() {
+  if (anchor_widget_) {

[msw, 2012/04/24 18:10:41]

nit: use anchor_widget() here and @line168 for r-value access.

[sadrul, 2012/04/24 18:15:42]

I think we actually prefer directly using the variable (at least in the rest of
the views code). (see all the uses of parent_ in view.cc for example)

[msw, 2012/04/24 18:24:58]

Fair enough.

+    anchor_widget_->RemoveObserver(this);
+    anchor_widget_ = NULL;

[msw, 2012/04/24 18:10:41]

Sorry, would you mind also setting anchor_view_ to null here?

[sadrul, 2012/04/24 18:15:42]

Done.

+  }
+}
+
 BubbleDelegateView* BubbleDelegateView::AsBubbleDelegate() {
   return this;
 }
 
 View* BubbleDelegateView::GetContentsView() {
   return this;
 }
 
 NonClientFrameView* BubbleDelegateView::CreateNonClientFrameView(
     Widget* widget) {
@@ skipping 149 matching lines @@
 
 #if defined(OS_WIN) && !defined(USE_AURA)
 gfx::Rect BubbleDelegateView::GetBubbleClientBounds() const {
   gfx::Rect client_bounds(GetBubbleFrameView()->GetBoundsForClientView());
   client_bounds.Offset(border_widget_->GetWindowScreenBounds().origin());
   return client_bounds;
 }
 #endif
 
 }  // namespace views