Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: ui/gfx/point.h

Issue 10203004: no virtual destructor for point/size/rect (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/point_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/point.h
diff --git a/ui/gfx/point.h b/ui/gfx/point.h
index 27bf09817f241e9bdd733c0e1aae03d218fdb852..156cba21a9f5a860ceee8d4eb2d91faad649bb00 100644
--- a/ui/gfx/point.h
+++ b/ui/gfx/point.h
@@ -34,7 +34,7 @@ class UI_EXPORT Point : public PointBase<Point, int> {
explicit Point(const CGPoint& point);
#endif
- virtual ~Point() {}
+ ~Point() {}
sky 2012/04/24 17:41:14 Move the destructors to be protected so we know no
jbates 2012/04/24 17:44:47 The PointBase destructor is protected. Might be he
oshima 2012/04/24 17:54:10 Yes, this dtor needs to be still public. All base
#if defined(OS_WIN)
POINT ToPOINT() const;
« no previous file with comments | « no previous file | ui/gfx/point_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698