Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: net/url_request/url_request_context.cc

Issue 10203002: Make URLRequestThrottlerManager a member of URLRequestContext. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to review comments. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/url_request/url_request_context.h ('k') | net/url_request/url_request_context_storage.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_context.h" 5 #include "net/url_request/url_request_context.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/debug/alias.h" 8 #include "base/debug/alias.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "net/base/host_resolver.h" 10 #include "net/base/host_resolver.h"
(...skipping 13 matching lines...) Expand all
24 fraudulent_certificate_reporter_(NULL), 24 fraudulent_certificate_reporter_(NULL),
25 http_auth_handler_factory_(NULL), 25 http_auth_handler_factory_(NULL),
26 proxy_service_(NULL), 26 proxy_service_(NULL),
27 network_delegate_(NULL), 27 network_delegate_(NULL),
28 http_server_properties_(NULL), 28 http_server_properties_(NULL),
29 transport_security_state_(NULL), 29 transport_security_state_(NULL),
30 ftp_auth_cache_(new FtpAuthCache), 30 ftp_auth_cache_(new FtpAuthCache),
31 http_transaction_factory_(NULL), 31 http_transaction_factory_(NULL),
32 ftp_transaction_factory_(NULL), 32 ftp_transaction_factory_(NULL),
33 job_factory_(NULL), 33 job_factory_(NULL),
34 throttler_manager_(NULL),
34 url_requests_(new std::set<const URLRequest*>) { 35 url_requests_(new std::set<const URLRequest*>) {
35 } 36 }
36 37
37 void URLRequestContext::CopyFrom(URLRequestContext* other) { 38 void URLRequestContext::CopyFrom(URLRequestContext* other) {
38 // Copy URLRequestContext parameters. 39 // Copy URLRequestContext parameters.
39 set_net_log(other->net_log()); 40 set_net_log(other->net_log());
40 set_host_resolver(other->host_resolver()); 41 set_host_resolver(other->host_resolver());
41 set_cert_verifier(other->cert_verifier()); 42 set_cert_verifier(other->cert_verifier());
42 set_server_bound_cert_service(other->server_bound_cert_service()); 43 set_server_bound_cert_service(other->server_bound_cert_service());
43 set_fraudulent_certificate_reporter(other->fraudulent_certificate_reporter()); 44 set_fraudulent_certificate_reporter(other->fraudulent_certificate_reporter());
44 set_http_auth_handler_factory(other->http_auth_handler_factory()); 45 set_http_auth_handler_factory(other->http_auth_handler_factory());
45 set_proxy_service(other->proxy_service()); 46 set_proxy_service(other->proxy_service());
46 set_ssl_config_service(other->ssl_config_service()); 47 set_ssl_config_service(other->ssl_config_service());
47 set_network_delegate(other->network_delegate()); 48 set_network_delegate(other->network_delegate());
48 set_http_server_properties(other->http_server_properties()); 49 set_http_server_properties(other->http_server_properties());
49 set_cookie_store(other->cookie_store()); 50 set_cookie_store(other->cookie_store());
50 set_transport_security_state(other->transport_security_state()); 51 set_transport_security_state(other->transport_security_state());
51 // FTPAuthCache is unique per context. 52 // FTPAuthCache is unique per context.
52 set_accept_language(other->accept_language()); 53 set_accept_language(other->accept_language());
53 set_accept_charset(other->accept_charset()); 54 set_accept_charset(other->accept_charset());
54 set_referrer_charset(other->referrer_charset()); 55 set_referrer_charset(other->referrer_charset());
55 set_http_transaction_factory(other->http_transaction_factory()); 56 set_http_transaction_factory(other->http_transaction_factory());
56 set_ftp_transaction_factory(other->ftp_transaction_factory()); 57 set_ftp_transaction_factory(other->ftp_transaction_factory());
57 set_job_factory(other->job_factory()); 58 set_job_factory(other->job_factory());
59 set_throttler_manager(other->throttler_manager());
58 } 60 }
59 61
60 void URLRequestContext::set_cookie_store(CookieStore* cookie_store) { 62 void URLRequestContext::set_cookie_store(CookieStore* cookie_store) {
61 cookie_store_ = cookie_store; 63 cookie_store_ = cookie_store;
62 } 64 }
63 65
64 const std::string& URLRequestContext::GetUserAgent(const GURL& url) const { 66 const std::string& URLRequestContext::GetUserAgent(const GURL& url) const {
65 return EmptyString(); 67 return EmptyString();
66 } 68 }
67 69
68 void URLRequestContext::AssertNoURLRequests() const { 70 void URLRequestContext::AssertNoURLRequests() const {
69 int num_requests = url_requests_->size(); 71 int num_requests = url_requests_->size();
70 if (num_requests != 0) { 72 if (num_requests != 0) {
71 // We're leaking URLRequests :( Dump the URL of the first one and record how 73 // We're leaking URLRequests :( Dump the URL of the first one and record how
72 // many we leaked so we have an idea of how bad it is. 74 // many we leaked so we have an idea of how bad it is.
73 char url_buf[128]; 75 char url_buf[128];
74 const URLRequest* request = *url_requests_->begin(); 76 const URLRequest* request = *url_requests_->begin();
75 base::strlcpy(url_buf, request->url().spec().c_str(), arraysize(url_buf)); 77 base::strlcpy(url_buf, request->url().spec().c_str(), arraysize(url_buf));
76 base::debug::Alias(url_buf); 78 base::debug::Alias(url_buf);
77 base::debug::Alias(&num_requests); 79 base::debug::Alias(&num_requests);
78 CHECK(false); 80 CHECK(false);
79 } 81 }
80 } 82 }
81 83
82 URLRequestContext::~URLRequestContext() { 84 URLRequestContext::~URLRequestContext() {
83 AssertNoURLRequests(); 85 AssertNoURLRequests();
84 } 86 }
85 87
86 } // namespace net 88 } // namespace net
OLDNEW
« no previous file with comments | « net/url_request/url_request_context.h ('k') | net/url_request/url_request_context_storage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698