Issue 102015: Add a very basic preferences window controller with unit test. Fix the prefs ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 102015: Add a very basic preferences window controller with unit test. Fix the prefs ... (Closed)

Created:
11 years, 7 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add a very basic preferences window controller with unit test. Fix the prefs nib to know the FileOwner is a NSWindowController and hook them together. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14958

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+141 lines, -7 lines)			Patch
M	chrome/app/nibs/en.lproj/Preferences.xib	View	4 chunks	+24 lines, -5 lines	0 comments	Download
M	chrome/browser/app_controller_mac.mm	View	3 chunks	+8 lines, -2 lines	0 comments	Download
A	chrome/browser/cocoa/preferences_window_controller.h	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/preferences_window_controller.mm	View	1 chunk	+49 lines, -0 lines	1 comment	Download
A	chrome/browser/cocoa/preferences_window_controller_unittest.mm	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

TVL

11 years, 7 months ago (2009-04-30 17:50:31 UTC) #2

lgtm

http://codereview.chromium.org/102015/diff/1/3
File chrome/browser/cocoa/preferences_window_controller.mm (right):

http://codereview.chromium.org/102015/diff/1/3#newcode28
Line 28: 
todo?

Expand Messages | Collapse Messages