Rewrite plugin_tests.cc to use FilePath and file_utils.h instead...

Rewrite plugin_tests.cc to use FilePath and file_utils.h instead
of Windows file & string manipulation, enable plugin tests on the Mac.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14968

[Mark Mentovai, 2009-04-30 18:01:33]

LGTM

http://codereview.chromium.org/102014/diff/2002/2004
File webkit/tools/test_shell/plugin_tests.cc (right):

http://codereview.chromium.org/102014/diff/2002/2004#newcode36
Line 36: PathService::Get(base::DIR_EXE, &current_directory);
current_directory is not the right name for this, is it?

[Amanda Walker, 2009-04-30 18:15:40]

On 2009/04/30 18:01:33, Mark Mentovai wrote:
> http://codereview.chromium.org/102014/diff/2002/2004#newcode36
> Line 36: PathService::Get(base::DIR_EXE, &current_directory);
> current_directory is not the right name for this, is it?

Hmm.  I suppose not--I wasn't changing the semantics of the test, so I didn't
think of renaming stuff.  "build_directory", maybe?  Suggestions welcome...

[Amanda Walker, 2009-04-30 18:36:29]

On 2009/04/30 18:01:33, Mark Mentovai wrote:
> Line 36: PathService::Get(base::DIR_EXE, &current_directory);
> current_directory is not the right name for this, is it?

Changed to "executable_directory", also fixed plugin cleanup so that the test
will run twice in a row :-).  Will commit as soon as the tree opens.