Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3541)

Unified Diff: chrome/browser/ui/views/browser_actions_container.cc

Issue 10201016: Conflict detection for Extension Keybinding. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Addressed comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/browser_actions_container.cc
===================================================================
--- chrome/browser/ui/views/browser_actions_container.cc (revision 134889)
+++ chrome/browser/ui/views/browser_actions_container.cc (working copy)
@@ -9,6 +9,8 @@
#include "base/string_util.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/extensions/extension_browser_event_router.h"
+#include "chrome/browser/extensions/extension_command_service.h"
+#include "chrome/browser/extensions/extension_command_service_factory.h"
#include "chrome/browser/extensions/extension_context_menu_model.h"
#include "chrome/browser/extensions/extension_host.h"
#include "chrome/browser/extensions/extension_service.h"
@@ -118,8 +120,11 @@
UpdateState();
}
+ ExtensionCommandService* command_service =
+ ExtensionCommandServiceFactory::GetForProfile(
+ panel_->browser()->profile());
const Extension::ExtensionKeybinding* browser_action_command =
- extension_->browser_action_command();
+ command_service->GetActiveBrowserActionCommand(extension_->id());
if (browser_action_command) {
keybinding_.reset(new ui::Accelerator(
browser_action_command->accelerator()));
@@ -308,7 +313,6 @@
BrowserActionButton::~BrowserActionButton() {
}
-
////////////////////////////////////////////////////////////////////////////////
// BrowserActionView
« no previous file with comments | « chrome/browser/ui/gtk/location_bar_view_gtk.cc ('k') | chrome/browser/ui/views/extensions/extension_installed_bubble.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698