Conflict detection for Extension Keybinding.

chrome/browser/extensions/extension_command_service_factory.h

Index: chrome/browser/extensions/extension_command_service_factory.h
===================================================================
--- chrome/browser/extensions/extension_command_service_factory.h	(revision 0)
+++ chrome/browser/extensions/extension_command_service_factory.h	(revision 0)
@@ -0,0 +1,40 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_COMMAND_SERVICE_FACTORY_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTENSION_COMMAND_SERVICE_FACTORY_H_
+#pragma once
+
+#include "base/memory/singleton.h"
+#include "chrome/browser/profiles/profile_keyed_service_factory.h"
+
+class ExtensionCommandService;
+
+// Singleton that owns all ExtensionCommandService and associates them with

[Aaron Boodman, 2012/04/30 17:48:12]

I don't think there's an ownership relationship... the PKS infrastructure ends
up owning the ExtensionCommandService instances. This is just the factory.

[Finnur, 2012/05/02 13:50:45]

Yeah, I used another factory as a template and did search-replace to add
ExtensionCommandService. Then forgot to revise the comment.

On 2012/04/30 17:48:12, Aaron Boodman wrote:

+// Profiles. Listens for the Profile's destruction notification and cleans up
+// the associated ExtensionCommandService.
+class ExtensionCommandServiceFactory : public ProfileKeyedServiceFactory {
+ public:
+  static ExtensionCommandService* GetForProfile(Profile* profile);
+
+  static ExtensionCommandServiceFactory* GetInstance();
+
+  // Overridden from ProfileKeyedBaseFactory:
+  virtual bool ServiceIsCreatedWithProfile() OVERRIDE;
+
+ private:
+  friend struct DefaultSingletonTraits<ExtensionCommandServiceFactory>;
+
+  ExtensionCommandServiceFactory();
+  virtual ~ExtensionCommandServiceFactory();
+
+  // ProfileKeyedServiceFactory:
+  virtual ProfileKeyedService* BuildServiceInstanceFor(
+      Profile* profile) const OVERRIDE;
+  virtual bool ServiceRedirectedInIncognito() OVERRIDE;
+
+  DISALLOW_COPY_AND_ASSIGN(ExtensionCommandServiceFactory);
+};
+
+#endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_COMMAND_SERVICE_FACTORY_H_
Property changes on: chrome\browser\extensions\extension_command_service_factory.h
___________________________________________________________________
Added: svn:eol-style
   + LF