Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4430)

Unified Diff: chrome/browser/ui/views/location_bar/page_action_image_view.cc

Issue 10201016: Conflict detection for Extension Keybinding. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/page_action_image_view.cc
===================================================================
--- chrome/browser/ui/views/location_bar/page_action_image_view.cc (revision 133458)
+++ chrome/browser/ui/views/location_bar/page_action_image_view.cc (working copy)
@@ -7,6 +7,7 @@
#include "base/utf_string_conversions.h"
#include "chrome/browser/extensions/extension_browser_event_router.h"
#include "chrome/browser/extensions/extension_context_menu_model.h"
+#include "chrome/browser/extensions/extension_keybinding_registry.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_tab_util.h"
#include "chrome/browser/platform_util.h"
@@ -63,7 +64,8 @@
set_accessibility_focusable(true);
const Extension::ExtensionKeybinding* page_action_command =
- extension->page_action_command();
+ ExtensionKeybindingRegistry::GetActivePageActionCommand(
+ browser_->profile(), extension->id());
if (page_action_command) {
keybinding_.reset(new ui::Accelerator(page_action_command->accelerator()));
owner_->GetFocusManager()->RegisterAccelerator(

Powered by Google App Engine
This is Rietveld 408576698