Issue 102010: Implement dropping of tabs into an existing tab strip from another window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 102010: Implement dropping of tabs into an existing tab strip from another window. (Closed)

Created:
11 years, 7 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Implement dropping of tabs into an existing tab strip from another window. Implement dragging and dropping of tabs within a window. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14879

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -40 lines)			Patch
M	chrome/browser/cocoa/browser_window_controller.mm	View		1 chunk	+42 lines, -6 lines	1 comment	Download
M	chrome/browser/cocoa/tab_strip_controller.h	View		1 chunk	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/tab_strip_controller.mm	View	1	3 chunks	+58 lines, -5 lines	0 comments	Download
M	chrome/browser/cocoa/tab_view.mm	View		5 chunks	+30 lines, -23 lines	0 comments	Download
M	chrome/browser/cocoa/tab_window_controller.h	View		2 chunks	+17 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/tab_window_controller.mm	View		2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

TVL

11 years, 7 months ago (2009-04-29 19:42:01 UTC) #2

lgtm

http://codereview.chromium.org/102010/diff/1003/2012
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/102010/diff/1003/2012#newcode293
Line 293: BrowserWindowController* dragBWC =
(BrowserWindowController*)dragController;
nit: maybe do the cast after the class check, just so reading it in order,
you're proving it good before the cast?

Expand Messages | Collapse Messages