Issue 102007: Free gtk list. Should fix valgrind warning...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 102007: Free gtk list. Should fix valgrind warning... (Closed)

Created:
11 years, 8 months ago by dank

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Free gtk list. Should fix valgrind warning 24 (12 direct, 12 indirect) bytes in 1 blocks are definitely lost in loss record 54 of 258 at malloc (vg_replace_malloc.c:178) ... by gtk_container_foreach (in /usr/lib/libgtk-x11-2.0.so.0.1200.9) by gtk_container_get_children (in /usr/lib/libgtk-x11-2.0.so.0.1200.9) by (anonymous namespace)::OnDialogResponse(_GtkDialog*, int, AppModalDialog*) (app_modal_dialog_gtk.cc:24) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14855

Patch Set 1 #

Created: 11 years, 8 months ago

		Unified diffs	Side-by-side diffs	Stats (+4 lines, -2 lines)
	M	chrome/browser/app_modal_dialog_gtk.cc	View	1 chunk	+4 lines, -2 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sorry about that.  LGTM!

Expand Messages | Collapse Messages