Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 10200015: [cros] Button focus polishing on the login screen. (Closed)

Created:
8 years, 8 months ago by Ivan Korotkov
Modified:
8 years, 8 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org
Visibility:
Public.

Description

[cros] Button focus polishing on the login screen. BUG=122771 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133914

Patch Set 1 #

Patch Set 2 : Refactoring, equal spacing. #

Patch Set 3 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -18 lines) Patch
M chrome/browser/resources/chromeos/login/header_bar.css View 1 2 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/resources/chromeos/login/header_bar.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.css View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/user_pod_row.css View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Ivan Korotkov
8 years, 8 months ago (2012-04-24 14:18:39 UTC) #1
Nikita (slow)
lgtm
8 years, 8 months ago (2012-04-25 12:03:10 UTC) #2
Ivan Korotkov
I've refactored HTML a little and fixed spacing between header bar items to be equal.
8 years, 8 months ago (2012-04-25 12:21:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10200015/3001
8 years, 8 months ago (2012-04-25 13:13:58 UTC) #4
commit-bot: I haz the power
Can't apply patch for file chrome/browser/resources/chromeos/login/user_pod_row.css. While running patch -p1 --forward --force; patching file chrome/browser/resources/chromeos/login/user_pod_row.css ...
8 years, 8 months ago (2012-04-25 13:14:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10200015/8001
8 years, 8 months ago (2012-04-25 13:39:35 UTC) #6
Nikita (slow)
still lgtm
8 years, 8 months ago (2012-04-25 14:15:26 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 15:02:34 UTC) #8
Change committed as 133914

Powered by Google App Engine
This is Rietveld 408576698