Issue 10198035: Fix warnings in libusb.h so that other chromium code doesn't suffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10198035: Fix warnings in libusb.h so that other chromium code doesn't suffer. (Closed)

Created:
8 years, 8 months ago by Garret Kelly

Modified:
8 years, 8 months ago

Reviewers:
sadrul

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix warnings in libusb.h so that other chromium code doesn't suffer. This change fixes a warning in libusb.h so that normal (warning-as-error) code in the rest of chromium can include it cleanly. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134183

Patch Set 1 #

Patch Set 2 : More WIN chicanery. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -15 lines)			Patch
M	third_party/libusb/libusb/libusb.h	View	1	2 chunks	+10 lines, -3 lines	0 comments	Download
M	third_party/libusb/libusb/os/poll_windows.h	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	third_party/libusb/windows-build.patch	View	1	3 chunks	+46 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gdk@chromium.org/10198035/1

8 years, 8 months ago (2012-04-26 19:31:02 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gdk@chromium.org/10198035/7002

8 years, 8 months ago (2012-04-26 21:06:47 UTC) #3

Change committed as 134183

Expand Messages | Collapse Messages